unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Attila Lendvai <attila@lendvai.name>
Cc: 61292@debbugs.gnu.org
Subject: bug#61292: define-public fontconfig vs. fontconfig-minimal as its name
Date: Wed, 15 Feb 2023 22:24:48 -0500	[thread overview]
Message-ID: <87o7puwav3.fsf@gmail.com> (raw)
In-Reply-To: <SrbV987TU079e3orC1S59uhxgE0VTkSELMNBgushO45ve_KIbjFIWTp8sHU1ArlXApcvkXbPZcK9dTxpBnLV-YauM9vz9NSwWGQna3TBYeg=@lendvai.name> (Attila Lendvai's message of "Sun, 05 Feb 2023 11:43:27 +0000")

Hi,

Attila Lendvai <attila@lendvai.name> writes:

> (define-public fontconfig
> [...]
>      (name "fontconfig-minimal")
>
> this tripped me up. is this a mistake?
>
> if not, then please add a comment that explains this anomaly.

There's already a comment above fontconfig-with-documentation that
reads:

  This is intentionally named 'fontconfig', as it's intended as the
  user-facing fontconfig package

The original fontconfig was renamed fontconfig-minimal but the variable
was not renamed to avoid having to adjust the rest of the code base.  It
could be done, and then the fontconfig-with-documentation *variable*
could be renamed to simply fontconfig.

That'd be more conventional.

Would you like to give it a try?  It shouldn't cause any rebuild, I
think.

-- 
Thanks,
Maxim




  reply	other threads:[~2023-02-16  3:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-05 11:43 bug#61292: define-public fontconfig vs. fontconfig-minimal as its name Attila Lendvai
2023-02-16  3:24 ` Maxim Cournoyer [this message]
2023-08-03 15:32 ` bug#61292: fontconfig -> fontconfig-minimal Attila Lendvai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7puwav3.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=61292@debbugs.gnu.org \
    --cc=attila@lendvai.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).