* bug#38782: portaudio fails to build
@ 2019-12-28 21:48 Sergiu Marton
2019-12-28 23:08 ` Ricardo Wurmus
0 siblings, 1 reply; 9+ messages in thread
From: Sergiu Marton @ 2019-12-28 21:48 UTC (permalink / raw)
To: 38782
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
I have mpv installed, which depends on rsound, which, in turn, depends
on portaudio. Since my last guix pull, portaudio fails to build - it
fails during the build phase. I attached the build log. I tried
reading it, but I don't know what to make of it.
[-- Attachment #2: portaudio-log.bz2 --]
[-- Type: application/octet-stream, Size: 11035 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#38782: portaudio fails to build
2019-12-28 21:48 bug#38782: portaudio fails to build Sergiu Marton
@ 2019-12-28 23:08 ` Ricardo Wurmus
2019-12-29 7:48 ` Sergiu Marton
0 siblings, 1 reply; 9+ messages in thread
From: Ricardo Wurmus @ 2019-12-28 23:08 UTC (permalink / raw)
To: Sergiu Marton; +Cc: 38782, Nicolas Goaziou
Sergiu Marton <brown121407@gmail.com> writes:
> I have mpv installed, which depends on rsound, which, in turn, depends
> on portaudio. Since my last guix pull, portaudio fails to build - it
> fails during the build phase. I attached the build log. I tried
> reading it, but I don't know what to make of it.
I have been able to build it locally. I suppose the problem might be
with parallel building. Disabling parallel builds for the portaudio
package might fix this.
--
Ricardo
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#38782: portaudio fails to build
2019-12-28 23:08 ` Ricardo Wurmus
@ 2019-12-29 7:48 ` Sergiu Marton
2019-12-29 8:43 ` Nicolas Goaziou
0 siblings, 1 reply; 9+ messages in thread
From: Sergiu Marton @ 2019-12-29 7:48 UTC (permalink / raw)
To: 38782-done
> I have been able to build it locally. I suppose the problem might be
> with parallel building. Disabling parallel builds for the portaudio
> package might fix this.
It built just fine with --cores=1 --max-jobs=1. Thanks!
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#38782: portaudio fails to build
2019-12-29 7:48 ` Sergiu Marton
@ 2019-12-29 8:43 ` Nicolas Goaziou
2019-12-29 8:59 ` Sergiu Marton
0 siblings, 1 reply; 9+ messages in thread
From: Nicolas Goaziou @ 2019-12-29 8:43 UTC (permalink / raw)
To: 38782; +Cc: brown121407
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
Hello,
Sergiu Marton <brown121407@gmail.com> writes:
>> I have been able to build it locally. I suppose the problem might be
>> with parallel building. Disabling parallel builds for the portaudio
>> package might fix this.
>
> It built just fine with --cores=1 --max-jobs=1. Thanks!
Would the following patch fix the issue then?
Regards,
--
Nicolas Goaziou
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Fix Portaudio build --]
[-- Type: text/x-diff, Size: 955 bytes --]
From 8acdc1540661bc80e8c724f29b6b162ccfb3307e Mon Sep 17 00:00:00 2001
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date: Sun, 29 Dec 2019 09:36:44 +0100
Subject: [PATCH] gnu: portaudio: Fix build.
* gnu/packages/audio.scm (portaudio)[arguments]: Build sequentially.
Fixes <https://bugs.gnu.org/38782>. This is a follow-up to commit
1ce6bfc21ce328d787df76c6ee132f9f828d098b.
---
gnu/packages/audio.scm | 1 +
1 file changed, 1 insertion(+)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 204ea6acf0..a76a48d4c6 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2874,6 +2874,7 @@ portions of LAME.")
("pkg-config" ,pkg-config)))
(arguments
'(#:tests? #f ;no 'check' target
+ #:parallel-build? #f
#:configure-flags '("--with-pic"
"--enable-cxx"
;; XXX: The following prevents a build error
--
2.24.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* bug#38782: portaudio fails to build
2019-12-29 8:43 ` Nicolas Goaziou
@ 2019-12-29 8:59 ` Sergiu Marton
2019-12-29 9:36 ` brettg
0 siblings, 1 reply; 9+ messages in thread
From: Sergiu Marton @ 2019-12-29 8:59 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 38782
> Would the following patch fix the issue then?
That fixes it without requiring extra CLI arguments. Nice, thanks.
On Sun, Dec 29, 2019 at 8:44 AM Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>
> Hello,
>
> Sergiu Marton <brown121407@gmail.com> writes:
>
> >> I have been able to build it locally. I suppose the problem might be
> >> with parallel building. Disabling parallel builds for the portaudio
> >> package might fix this.
> >
> > It built just fine with --cores=1 --max-jobs=1. Thanks!
>
> Would the following patch fix the issue then?
>
> Regards,
>
> --
> Nicolas Goaziou
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#38782: portaudio fails to build
2019-12-29 8:59 ` Sergiu Marton
@ 2019-12-29 9:36 ` brettg
2019-12-29 9:43 ` Nicolas Goaziou
0 siblings, 1 reply; 9+ messages in thread
From: brettg @ 2019-12-29 9:36 UTC (permalink / raw)
To: Sergiu Marton; +Cc: 38782, bug-Guix, Nicolas Goaziou
On 29.12.2019 09:59, Sergiu Marton wrote:
>> Would the following patch fix the issue then?
>
> That fixes it without requiring extra CLI arguments. Nice, thanks.
>
> On Sun, Dec 29, 2019 at 8:44 AM Nicolas Goaziou
> <mail@nicolasgoaziou.fr> wrote:
>>
>> Hello,
>>
>> Sergiu Marton <brown121407@gmail.com> writes:
>>
>> >> I have been able to build it locally. I suppose the problem might be
>> >> with parallel building. Disabling parallel builds for the portaudio
>> >> package might fix this.
>> >
>> > It built just fine with --cores=1 --max-jobs=1. Thanks!
>>
>> Would the following patch fix the issue then?
>>
>> Regards,
>>
>> --
>> Nicolas Goaziou
I would personally comment the reason for disabling parallel builds and
affix this bug number to the commit sub-header message. I am at work
right now, so I lack the ability to do this myself at the moment. But if
I get home and this issue is still open, I will do it. It's up for grabs
if somebody beats me to it.
Best,
Brett Gilio
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#38782: portaudio fails to build
2019-12-29 9:36 ` brettg
@ 2019-12-29 9:43 ` Nicolas Goaziou
2019-12-29 9:45 ` brettg
0 siblings, 1 reply; 9+ messages in thread
From: Nicolas Goaziou @ 2019-12-29 9:43 UTC (permalink / raw)
To: brettg; +Cc: 38782, bug-Guix, Sergiu Marton
Hello,
brettg@posteo.net writes:
> I would personally comment the reason for disabling parallel builds
You mean as a comment in the package definition? I checked other
definitions, comments in this situation, if any, are terse. E.g.,
";fails on some systems".
> and affix this bug number to the commit sub-header message.
I added the bug reference to the commit message. Do you mean it should
be moved right after the commit title (separated by a blank line)?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#38782: portaudio fails to build
2019-12-29 9:43 ` Nicolas Goaziou
@ 2019-12-29 9:45 ` brettg
2019-12-29 10:07 ` Nicolas Goaziou
0 siblings, 1 reply; 9+ messages in thread
From: brettg @ 2019-12-29 9:45 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: Sergiu Marton, 38782, bug-Guix, bug-Guix
On 29.12.2019 10:43, Nicolas Goaziou wrote:
> Hello,
>
> brettg@posteo.net writes:
>
>> I would personally comment the reason for disabling parallel builds
>
> You mean as a comment in the package definition? I checked other
> definitions, comments in this situation, if any, are terse. E.g.,
> ";fails on some systems".
>
>> and affix this bug number to the commit sub-header message.
>
> I added the bug reference to the commit message. Do you mean it should
> be moved right after the commit title (separated by a blank line)?
>
> Regards,
On a second look, your commit message is fine. And the `; fails on some
systems` seems fine to me. Sorry, I am quite sleep deprived right now.
:)
Best,
Brett Gilio
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#38782: portaudio fails to build
2019-12-29 9:45 ` brettg
@ 2019-12-29 10:07 ` Nicolas Goaziou
0 siblings, 0 replies; 9+ messages in thread
From: Nicolas Goaziou @ 2019-12-29 10:07 UTC (permalink / raw)
To: brettg; +Cc: Sergiu Marton, 38782, bug-Guix, bug-Guix
brettg@posteo.net writes:
> On 29.12.2019 10:43, Nicolas Goaziou wrote:
>> Hello,
>>
>> brettg@posteo.net writes:
>>
>>> I would personally comment the reason for disabling parallel builds
>>
>> You mean as a comment in the package definition? I checked other
>> definitions, comments in this situation, if any, are terse. E.g.,
>> ";fails on some systems".
>>
>>> and affix this bug number to the commit sub-header message.
>>
>> I added the bug reference to the commit message. Do you mean it should
>> be moved right after the commit title (separated by a blank line)?
>>
>> Regards,
>
> On a second look, your commit message is fine. And the `; fails on
> some systems` seems fine to me. Sorry, I am quite sleep deprived right
> now. :)
Great. I applied the patch. All the credit goes to Ricardo Wurmus for
the fix.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-12-29 10:09 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-28 21:48 bug#38782: portaudio fails to build Sergiu Marton
2019-12-28 23:08 ` Ricardo Wurmus
2019-12-29 7:48 ` Sergiu Marton
2019-12-29 8:43 ` Nicolas Goaziou
2019-12-29 8:59 ` Sergiu Marton
2019-12-29 9:36 ` brettg
2019-12-29 9:43 ` Nicolas Goaziou
2019-12-29 9:45 ` brettg
2019-12-29 10:07 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).