From mboxrd@z Thu Jan  1 00:00:00 1970
From: brettg@posteo.net
Subject: bug#38782: portaudio fails to build
Date: Sun, 29 Dec 2019 10:45:33 +0100
Message-ID: <da5ef7bf9763ce6de1c6c77216dde87c@posteo.net>
References: <CAJ=hFwTGMQ+Hsi4K1QTuZiH3czxnakU1Fg2BxaL7YukXhmQX7w@mail.gmail.com>
 <87h81knj4f.fsf@elephly.net>
 <CAJ=hFwSVxDyimyfAJJua9=+Gy4E7GOVgFL2Piwy8s63OXv3jDQ@mail.gmail.com>
 <878smv1pyo.fsf@nicolasgoaziou.fr>
 <CAJ=hFwQF-MJb92=X5UQvRktCoPkS7sir7zJYGMTTL-davLCFkQ@mail.gmail.com>
 <c7932d5d12c42f0e9984f4ca2230569e@posteo.net>
 <874kxj1n7t.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:43575)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ilV99-0001BO-27
 for bug-guix@gnu.org; Sun, 29 Dec 2019 04:46:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ilV98-00085O-5z
 for bug-guix@gnu.org; Sun, 29 Dec 2019 04:46:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:53289)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1ilV98-00084m-1X
 for bug-guix@gnu.org; Sun, 29 Dec 2019 04:46:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ilV98-0004bG-0A
 for bug-guix@gnu.org; Sun, 29 Dec 2019 04:46:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.38782.B38782.157761274117654@debbugs.gnu.org>
In-Reply-To: <874kxj1n7t.fsf@nicolasgoaziou.fr>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Sergiu Marton <brown121407@gmail.com>, 38782@debbugs.gnu.org, bug-Guix <bug-guix-bounces+brettg=posteo.net@gnu.org>, bug-Guix <bug-guix-bounces+brettg=gnu.org@gnu.org>



On 29.12.2019 10:43, Nicolas Goaziou wrote:
> Hello,
> 
> brettg@posteo.net writes:
> 
>> I would personally comment the reason for disabling parallel builds
> 
> You mean as a comment in the package definition? I checked other
> definitions, comments in this situation, if any, are terse. E.g.,
> ";fails on some systems".
> 
>> and affix this bug number to the commit sub-header message.
> 
> I added the bug reference to the commit message. Do you mean it should
> be moved right after the commit title (separated by a blank line)?
> 
> Regards,

On a second look, your commit message is fine. And the `; fails on some 
systems` seems fine to me. Sorry, I am quite sleep deprived right now. 
:)

Best,
Brett Gilio