From mboxrd@z Thu Jan 1 00:00:00 1970 From: brettg@posteo.net Subject: bug#38782: portaudio fails to build Date: Sun, 29 Dec 2019 10:45:33 +0100 Message-ID: References: <87h81knj4f.fsf@elephly.net> <878smv1pyo.fsf@nicolasgoaziou.fr> <874kxj1n7t.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:43575) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ilV99-0001BO-27 for bug-guix@gnu.org; Sun, 29 Dec 2019 04:46:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ilV98-00085O-5z for bug-guix@gnu.org; Sun, 29 Dec 2019 04:46:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53289) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ilV98-00084m-1X for bug-guix@gnu.org; Sun, 29 Dec 2019 04:46:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ilV98-0004bG-0A for bug-guix@gnu.org; Sun, 29 Dec 2019 04:46:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <874kxj1n7t.fsf@nicolasgoaziou.fr> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Nicolas Goaziou Cc: Sergiu Marton , 38782@debbugs.gnu.org, bug-Guix , bug-Guix On 29.12.2019 10:43, Nicolas Goaziou wrote: > Hello, > > brettg@posteo.net writes: > >> I would personally comment the reason for disabling parallel builds > > You mean as a comment in the package definition? I checked other > definitions, comments in this situation, if any, are terse. E.g., > ";fails on some systems". > >> and affix this bug number to the commit sub-header message. > > I added the bug reference to the commit message. Do you mean it should > be moved right after the commit title (separated by a blank line)? > > Regards, On a second look, your commit message is fine. And the `; fails on some systems` seems fine to me. Sorry, I am quite sleep deprived right now. :) Best, Brett Gilio