* bug#25762: bug#25772: [PATCH] guix package: Remove trailing slash from profile path.
[not found] ` <87d1ee2y8p.fsf@gmail.com>
@ 2017-07-20 13:31 ` Ludovic Courtès
0 siblings, 0 replies; only message in thread
From: Ludovic Courtès @ 2017-07-20 13:31 UTC (permalink / raw)
To: Alex Kost; +Cc: 25772-done, 25762-done
Hello!
Alex Kost <alezost@gmail.com> skribis:
> Ricardo Wurmus (2017-02-17 23:38 +0100) wrote:
>
> [...]
>>> (let* ((profiles (match (filter-map (match-lambda
>>> - (('profile . p) p)
>>> - (_ #f))
>>> + (('profile . p)
>>> + (readlink (string-trim-right p #\/)))
>>> + (_ #f))
>>> opts)
>>> (() (list %current-profile))
>>> (lst lst)))
>>
>> I don’t know if this is the right place for this change or if this
>> should be further upstream.
>
> I think it is not the right place: you modify only 'process-query'
> procedure, but there is also 'process-actions', so the following command
> will still fail:
>
> guix package -p /tmp/test-profile/ -i hello
>
> while the following succeeds:
>
> guix package -p /tmp/test-profile -i hello
>
> So I would rather modify 'canonicalize-profile' procedure in that
> module. I think it will be a general solution for --profile option.
Indeed. I pushed something along these lines as
edbe07cd67d6050d94fe8ac1af15ab15e857b61d, and a related fix as
561f4e450078a06c707d3dcda2cf0e7d6eb5ebae.
Thanks!
Ludo’.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-07-20 13:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20170217100054.25464-1-rekado@elephly.net>
[not found] ` <8737fctpc4.fsf@elephly.net>
[not found] ` <87d1ee2y8p.fsf@gmail.com>
2017-07-20 13:31 ` bug#25762: bug#25772: [PATCH] guix package: Remove trailing slash from profile path Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).