From: ludo@gnu.org (Ludovic Courtès)
To: Alex Kost <alezost@gmail.com>
Cc: 25772-done@debbugs.gnu.org, 25762-done@debbugs.gnu.org
Subject: bug#25762: bug#25772: [PATCH] guix package: Remove trailing slash from profile path.
Date: Thu, 20 Jul 2017 15:31:13 +0200 [thread overview]
Message-ID: <87y3rjutem.fsf@gnu.org> (raw)
In-Reply-To: <87d1ee2y8p.fsf@gmail.com> (Alex Kost's message of "Sun, 19 Feb 2017 14:53:10 +0300")
Hello!
Alex Kost <alezost@gmail.com> skribis:
> Ricardo Wurmus (2017-02-17 23:38 +0100) wrote:
>
> [...]
>>> (let* ((profiles (match (filter-map (match-lambda
>>> - (('profile . p) p)
>>> - (_ #f))
>>> + (('profile . p)
>>> + (readlink (string-trim-right p #\/)))
>>> + (_ #f))
>>> opts)
>>> (() (list %current-profile))
>>> (lst lst)))
>>
>> I don’t know if this is the right place for this change or if this
>> should be further upstream.
>
> I think it is not the right place: you modify only 'process-query'
> procedure, but there is also 'process-actions', so the following command
> will still fail:
>
> guix package -p /tmp/test-profile/ -i hello
>
> while the following succeeds:
>
> guix package -p /tmp/test-profile -i hello
>
> So I would rather modify 'canonicalize-profile' procedure in that
> module. I think it will be a general solution for --profile option.
Indeed. I pushed something along these lines as
edbe07cd67d6050d94fe8ac1af15ab15e857b61d, and a related fix as
561f4e450078a06c707d3dcda2cf0e7d6eb5ebae.
Thanks!
Ludo’.
parent reply other threads:[~2017-07-20 13:32 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <87d1ee2y8p.fsf@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3rjutem.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=25762-done@debbugs.gnu.org \
--cc=25772-done@debbugs.gnu.org \
--cc=alezost@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).