* bug#32539: Cuirass: a commit that updates doc will produce 86 tests
@ 2018-08-27 8:57 Clément Lassieur
2018-08-29 21:21 ` Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Clément Lassieur @ 2018-08-27 8:57 UTC (permalink / raw)
To: 32539
Evaluation 338[1] is triggered by commit 1d8d69c[2], which only updates
the documentation. This evaluation produces 86 useless tests:
test.mcron.i686-linux, test.opensmtpd.i686-linux, etc. I believe those
tests are triggered at each evaluation (almost), and it's a considerable
waste of resources.
[1]: https://berlin.guixsd.org/eval/338
[2]: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=1d8d69c863ae88d5fc20e52e49a22f68c531c1db
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#32539: Cuirass: a commit that updates doc will produce 86 tests
2018-08-27 8:57 bug#32539: Cuirass: a commit that updates doc will produce 86 tests Clément Lassieur
@ 2018-08-29 21:21 ` Ludovic Courtès
2018-08-29 22:07 ` Clément Lassieur
0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2018-08-29 21:21 UTC (permalink / raw)
To: Clément Lassieur; +Cc: 32539
Hi Clément,
Clément Lassieur <clement@lassieur.org> skribis:
> Evaluation 338[1] is triggered by commit 1d8d69c[2], which only updates
> the documentation. This evaluation produces 86 useless tests:
> test.mcron.i686-linux, test.opensmtpd.i686-linux, etc. I believe those
> tests are triggered at each evaluation (almost), and it's a considerable
> waste of resources.
I claim that these tests are useful and that having them under CI is a
good thing!
AFAICS the result of test.basic.*, test.mcron.*, etc. should be
unchanged when doc/*.texi are modified; if that’s not the case, we have
a bug. :-) So there’s no waste of resources in this case.
However the tests in (gnu tests install) do entail a full build of Guix
from the checkout, among other things, at every commit, so they are
expensive. They are useful though, so I’d rather keep it this way if
our build farm can keep up.
Thoughts?
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#32539: Cuirass: a commit that updates doc will produce 86 tests
2018-08-29 21:21 ` Ludovic Courtès
@ 2018-08-29 22:07 ` Clément Lassieur
2021-03-25 13:12 ` Mathieu Othacehe
0 siblings, 1 reply; 4+ messages in thread
From: Clément Lassieur @ 2018-08-29 22:07 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 32539
Heya!
Ludovic Courtès <ludo@gnu.org> writes:
> Hi Clément,
>
> Clément Lassieur <clement@lassieur.org> skribis:
>
>> Evaluation 338[1] is triggered by commit 1d8d69c[2], which only updates
>> the documentation. This evaluation produces 86 useless tests:
>> test.mcron.i686-linux, test.opensmtpd.i686-linux, etc. I believe those
>> tests are triggered at each evaluation (almost), and it's a considerable
>> waste of resources.
>
> I claim that these tests are useful and that having them under CI is a
> good thing!
>
> AFAICS the result of test.basic.*, test.mcron.*, etc. should be
> unchanged when doc/*.texi are modified; if that’s not the case, we have
> a bug. :-) So there’s no waste of resources in this case.
My point is that the derivations files are different at each commit,
despite the changes being only about documentation. It seems to me that
documentation is not an input of the tests, therefore the inputs didn't
change and the test derivations shouldn't change.
> However the tests in (gnu tests install) do entail a full build of Guix
> from the checkout, among other things, at every commit, so they are
> expensive. They are useful though, so I’d rather keep it this way if
> our build farm can keep up.
>
> Thoughts?
>
> Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-25 13:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-27 8:57 bug#32539: Cuirass: a commit that updates doc will produce 86 tests Clément Lassieur
2018-08-29 21:21 ` Ludovic Courtès
2018-08-29 22:07 ` Clément Lassieur
2021-03-25 13:12 ` Mathieu Othacehe
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).