* Re: Volatile? argument seems to be ignored for system disk images
[not found] <87wocxhih6.fsf@jlicht.xyz>
@ 2019-11-18 5:08 ` Maxim Cournoyer
0 siblings, 0 replies; only message in thread
From: Maxim Cournoyer @ 2019-11-18 5:08 UTC (permalink / raw)
To: Jelle Licht; +Cc: bug-guix, help-guix
Jelle Licht <jlicht@fsfe.org> writes:
> I am trying to dive into some of the code that goes into generating
> system disk images for guix, and I ran into the following:
>
> It seems that commit 932e1f92404d917a91af28737d6631ec45b56875 did more
> than what the commit log said:
>
>> vm: Make sure disk image initrds load 'usb-storage.ko'.
>>
>> Reported by David Thompson <dthompson2@worcester.edu>.
>>
>> * gnu/system/vm.scm (system-disk-image): Add usb-storage.ko to the
>> initrd.
>
> This commit effectively made the `#:volatile?' kwarg to
> `system-disk-image' redundant. Should we remove `#:volatile?', or should
> it be passed along instead of #t?
>
> Or am I misunderstanding something subtle here, and is everything as it
> should be?
No, my understanding is the same as yours: it looks like a bug.
Fixed with commit 67ed544212.
Thank you!
Maxim
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-11-18 5:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <87wocxhih6.fsf@jlicht.xyz>
2019-11-18 5:08 ` Volatile? argument seems to be ignored for system disk images Maxim Cournoyer
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).