From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: Re: Volatile? argument seems to be ignored for system disk images
Date: Mon, 18 Nov 2019 14:08:12 +0900
Message-ID: <87v9rhu5z7.fsf@gmail.com>
References: <87wocxhih6.fsf@jlicht.xyz>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <help-guix-bounces+gcggh-help-guix=m.gmane.org@gnu.org>
In-Reply-To: <87wocxhih6.fsf@jlicht.xyz> (Jelle Licht's message of "Mon, 21
 Oct 2019 23:55:01 +0200")
List-Unsubscribe: <https://lists.gnu.org/mailman/options/help-guix>,
 <mailto:help-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/help-guix>
List-Post: <mailto:help-guix@gnu.org>
List-Help: <mailto:help-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/help-guix>,
 <mailto:help-guix-request@gnu.org?subject=subscribe>
Errors-To: help-guix-bounces+gcggh-help-guix=m.gmane.org@gnu.org
Sender: "Help-Guix" <help-guix-bounces+gcggh-help-guix=m.gmane.org@gnu.org>
To: Jelle Licht <jlicht@fsfe.org>
Cc: bug-guix <bug-guix@gnu.org>, help-guix@gnu.org
List-Id: bug-guix.gnu.org

Jelle Licht <jlicht@fsfe.org> writes:

> I am trying to dive into some of the code that goes into generating
> system disk images for guix, and I ran into the following:
>
> It seems that commit 932e1f92404d917a91af28737d6631ec45b56875 did more
> than what the commit log said:
>
>> vm: Make sure disk image initrds load 'usb-storage.ko'.
>>
>> Reported by David Thompson <dthompson2@worcester.edu>.
>>
>> * gnu/system/vm.scm (system-disk-image): Add usb-storage.ko to the
>>   initrd.
>
> This commit effectively made the `#:volatile?' kwarg to
> `system-disk-image' redundant. Should we remove `#:volatile?', or should
> it be passed along instead of #t?
>
> Or am I misunderstanding something subtle here, and is everything as it
> should be?

No, my understanding is the same as yours: it looks like a bug.

Fixed with commit 67ed544212.

Thank you!

Maxim