From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: othacehe@gnu.org, 54786@debbugs.gnu.org
Subject: bug#54786: Installation tests are failing
Date: Thu, 02 Jun 2022 22:43:58 +0200 [thread overview]
Message-ID: <87v8tilrsh.fsf@gnu.org> (raw)
In-Reply-To: <877d5zx9jt.fsf@gmail.com> (Maxim Cournoyer's message of "Thu, 02 Jun 2022 13:24:54 -0400")
Howdy!
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> I tried capturing the issue in the commit message, but I'll provide
> another more hands-on view: the Jami service was broken due to changes
> in Shepherd 0.9.0 that caused the blocking sleeps + concurrent
> make+forkexec-constructor/container and fork+exec-command combination
> used to not work anymore.
OK. Thanks for sharing the strace log; at first sight I don’t see any
clear clue, but hey, maybe it’s fine to leave that as a mystery since
there’s another solution.
[...]
>> Longer-term I think this should go in Jami proper though. It’s great
>> that Guix has an edge over the competition :-), but having to maintain
>> it is less nice.
>
> Perhaps with the Scheme bindings introduced by Olivier for the Jami
> tests (that work via an embedded libguile), it could be possible to add
> the ability to pass an init script to 'jamid' at launch time, which
> would automate importing the account. Proper 'Scheme' bindings would be
> nice though, and I'd like to look into the feasibility to add these via
> Swig. Food for thought.
Sounds fun. (BTW, I’d recommend against SWIG: it’s not “pretty”, leaves
a lot of work to do, including wrapping the generated wrappers and
debugging memory management issue. Using the FFI provides more
flexibility and is much more fun IMO.)
>> Also, in more concrete terms: one goal of the least-authority work at
>> <https://issues.guix.gnu.org/54997> is to remove
>> ‘make-forkexec-constructor/container’ and the whole (gnu build shepherd)
>> module. Jami is one of its last remaining users (adjusting it felt like
>> beyond my abilities, precisely because it’s much more complex than the
>> other services I adjusted).
>>
>> Could you take a look at that eventually, once this patch has been
>> reviewed?
>
> I reviewed how that works, and it'd be easy; I just didn't see the
> incentive yet (there's no composition needed for the service, and it'd
> make the definition slightly less readable). If you tell me
> mark+forkexec-constructor/container is going the way of the Dodo though,
> that's a good enough incentive :-).
Awesome. :-)
Thanks for explaining!
Ludo’.
next prev parent reply other threads:[~2022-06-02 20:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 9:51 bug#54786: Installation tests are failing Mathieu Othacehe
2022-04-08 15:10 ` Mathieu Othacehe
2022-04-28 7:22 ` Mathieu Othacehe
2022-04-28 19:19 ` Ludovic Courtès
2022-04-29 19:50 ` Ludovic Courtès
2022-04-30 13:02 ` Mathieu Othacehe
2022-05-01 13:26 ` Ludovic Courtès
2022-05-25 3:43 ` Maxim Cournoyer
2022-05-28 21:29 ` Ludovic Courtès
2022-05-31 16:44 ` bug#54786: [PATCH] services: jami: Modernize to adjust to Shepherd 0.9+ changes Maxim Cournoyer
2022-06-01 9:54 ` bug#54786: Installation tests are failing Ludovic Courtès
2022-06-01 13:10 ` Maxim Cournoyer
2022-06-02 13:13 ` Ludovic Courtès
2022-06-02 17:24 ` Maxim Cournoyer
2022-06-02 20:43 ` Ludovic Courtès [this message]
2022-06-04 4:37 ` Maxim Cournoyer
2022-06-07 14:00 ` Ludovic Courtès
2022-06-08 0:58 ` bokr
2022-06-11 4:18 ` Maxim Cournoyer
2022-08-09 14:20 ` Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8tilrsh.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=54786@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).