unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: othacehe@gnu.org, 54786@debbugs.gnu.org
Subject: bug#54786: Installation tests are failing
Date: Sat, 11 Jun 2022 00:18:16 -0400	[thread overview]
Message-ID: <87h74rg7ef.fsf@gmail.com> (raw)
In-Reply-To: <877d5sbmjt.fsf@gnu.org> ("Ludovic Courtès"'s message of "Tue, 07 Jun 2022 16:00:54 +0200")

Hi Ludo,

Ludovic Courtès <ludo@gnu.org> writes:

[...]

>> When using 'make-forkexec-constructor/container', the clone(2) call
>> happens before switching user, thus as 'root' in Shepherd, which
>> explains why it works.
>
> Damnit, that’s right.  For example the result of:
>
>    (lower-object (least-authority-wrapper (file-append coreutils "/bin/uname")
>                                           #:namespaces (delq 'user %namespaces)))
>
> won’t run as an unprivileged user:

[...]

> I think we would add #:user and #:group to ‘least-authority-wrapper’ and
> have it call setuid/setgid.  ‘make-forkexec-constructor’ doesn’t need to
> be modified, but the user simply won’t pass #:user and #:group to it.

OK!  I'll adjust the jami-service-type when we get around to implement
the above; for now I've pushed my proposed fix which still uses
'make-forkexec-constructor/container' as
85b4dabd94d53f8179f31a42046cd83fc3a352fc.

Thanks,

Maxim




  parent reply	other threads:[~2022-06-11  4:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08  9:51 bug#54786: Installation tests are failing Mathieu Othacehe
2022-04-08 15:10 ` Mathieu Othacehe
2022-04-28  7:22   ` Mathieu Othacehe
2022-04-28 19:19     ` Ludovic Courtès
2022-04-29 19:50       ` Ludovic Courtès
2022-04-30 13:02         ` Mathieu Othacehe
2022-05-01 13:26           ` Ludovic Courtès
2022-05-25  3:43             ` Maxim Cournoyer
2022-05-28 21:29               ` Ludovic Courtès
2022-05-31 16:44                 ` bug#54786: [PATCH] services: jami: Modernize to adjust to Shepherd 0.9+ changes Maxim Cournoyer
2022-06-01  9:54                   ` bug#54786: Installation tests are failing Ludovic Courtès
2022-06-01 13:10                     ` Maxim Cournoyer
2022-06-02 13:13                       ` Ludovic Courtès
2022-06-02 17:24                         ` Maxim Cournoyer
2022-06-02 20:43                           ` Ludovic Courtès
2022-06-04  4:37                             ` Maxim Cournoyer
2022-06-07 14:00                               ` Ludovic Courtès
2022-06-08  0:58                                 ` bokr
2022-06-11  4:18                                 ` Maxim Cournoyer [this message]
2022-08-09 14:20                                   ` Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h74rg7ef.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=54786@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).