unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: othacehe@gnu.org, 54786@debbugs.gnu.org
Subject: bug#54786: Installation tests are failing
Date: Wed, 01 Jun 2022 11:54:09 +0200	[thread overview]
Message-ID: <87o7zcwvy6.fsf_-_@gnu.org> (raw)
In-Reply-To: <20220531164407.13914-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Tue, 31 May 2022 12:44:07 -0400")

Hi Maxim,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

>  gnu/build/dbus-service.scm | 212 ++++++++++++++++
>  gnu/build/jami-service.scm | 390 +++++------------------------
>  gnu/local.mk               |   1 +
>  gnu/packages/glib.scm      |  19 +-
>  gnu/services/telephony.scm | 500 +++++++++++++++++--------------------
>  gnu/tests/telephony.scm    | 412 +++++++++++++++---------------
>  6 files changed, 726 insertions(+), 808 deletions(-)
>  create mode 100644 gnu/build/dbus-service.scm

Before going further, I’d like to understand: this does more than just
fix the Jami system tests, right?

It would have been nice to have surgical changes to “just” fix the
tests, along the lines of <https://issues.guix.gnu.org/54786#9>,
possibly followed by a rework of the whole machinery, if that’s
possible.

Besides, I think we should talk to Jami upstream (which shouldn’t be too
hard :-)).  It doesn’t seem reasonable to me to have 800+ lines of code
in the distro to start one service.  Usually the ‘start’ and ‘stop’
methods are between 2 and 10 lines of code.

What do you think is missing upstream so that starting Jami is simpler?

Thanks,
Ludo’.




  reply	other threads:[~2022-06-01  9:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08  9:51 bug#54786: Installation tests are failing Mathieu Othacehe
2022-04-08 15:10 ` Mathieu Othacehe
2022-04-28  7:22   ` Mathieu Othacehe
2022-04-28 19:19     ` Ludovic Courtès
2022-04-29 19:50       ` Ludovic Courtès
2022-04-30 13:02         ` Mathieu Othacehe
2022-05-01 13:26           ` Ludovic Courtès
2022-05-25  3:43             ` Maxim Cournoyer
2022-05-28 21:29               ` Ludovic Courtès
2022-05-31 16:44                 ` bug#54786: [PATCH] services: jami: Modernize to adjust to Shepherd 0.9+ changes Maxim Cournoyer
2022-06-01  9:54                   ` Ludovic Courtès [this message]
2022-06-01 13:10                     ` bug#54786: Installation tests are failing Maxim Cournoyer
2022-06-02 13:13                       ` Ludovic Courtès
2022-06-02 17:24                         ` Maxim Cournoyer
2022-06-02 20:43                           ` Ludovic Courtès
2022-06-04  4:37                             ` Maxim Cournoyer
2022-06-07 14:00                               ` Ludovic Courtès
2022-06-08  0:58                                 ` bokr
2022-06-11  4:18                                 ` Maxim Cournoyer
2022-08-09 14:20                                   ` Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7zcwvy6.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=54786@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).