From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: John Soo <jsoo1@asu.edu>
Cc: francois.joulaud@radiofrance.com, 46925@debbugs.gnu.org
Subject: bug#46925: Ripgrep tests failures due to bstr update
Date: Wed, 10 Mar 2021 14:42:04 +0100 [thread overview]
Message-ID: <87sg532kib.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <629092da-8a9b-40ad-b7ec-62ac8ef38c23@Johns-iPhone> (John Soo's message of "Tue, 9 Mar 2021 07:39:33 -0800")
Hello,
John Soo <jsoo1@asu.edu> writes:
> I think the breaking tests do actually indicate breaking functionality
> in this case since there is a whole test suite dedicated to the
> bytestring representation.
I use ripgrep daily, and I haven't encountered a regression so far. Of
course, this proves nothing.
> Maybe the fix could be using a later commit
> in which the later bstr is used. There are definitely unreleased
> commits in ripgrep.
Latest ripgrep commit still requires bstr 0.2.12, so this is not an
option either.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2021-03-10 13:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 16:40 bug#46925: Ripgrep tests failures due to bstr update John Soo
2021-03-04 20:38 ` Nicolas Goaziou
2021-03-08 16:22 ` JOULAUD François via Bug reports for GNU Guix
2021-03-08 21:40 ` Nicolas Goaziou
2021-03-09 11:34 ` JOULAUD François via Bug reports for GNU Guix
2021-03-09 15:39 ` John Soo
2021-03-10 13:42 ` Nicolas Goaziou [this message]
2021-03-10 13:44 ` John Soo
2021-03-10 14:01 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg532kib.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=46925@debbugs.gnu.org \
--cc=francois.joulaud@radiofrance.com \
--cc=jsoo1@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).