unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "JOULAUD François via Bug reports for GNU Guix" <bug-guix@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: John Soo <jsoo1@asu.edu>,
	"46925@debbugs.gnu.org" <46925@debbugs.gnu.org>
Subject: bug#46925: Ripgrep tests failures due to bstr update
Date: Mon, 8 Mar 2021 16:22:02 +0000	[thread overview]
Message-ID: <20210308161856.rme6tdhbbr44zdev@fjo-extia-HPdeb.example.avalenn.eu> (raw)
In-Reply-To: <87mtvifycw.fsf@nicolasgoaziou.fr>

Hello,

On Thu, Mar 04, 2021 at 09:38:39PM +0100, Nicolas Goaziou wrote:
> John Soo <jsoo1@asu.edu> writes:
> 
> > I just talked to burntsushi on github about the failing ripgrep tests.
> > It looks like the version of bstr we are now using changed the
> > representation of bstrs and caused us test failures.  Changing the
> > version of bstr used in ripgrep@12.1.1 to 0.2.12 should fix the
> > problem.
> 
> I disabled tests in ripgrep a few hours ago for the same reason. This is
> not great, but I couldn't find another solution. In particular,
> replacing rust-bstr-0.2 with a special rust-bstr-0.2.12 did not work
> because regular rust-bstr-0.2 is still used as a transitive dependency.
> 
> Do you think of a better way to solve this?

Two possibilities seems to be possible here.

Upgrade rust-bstr-0.2 to be 0.2.12, possibly only upgrading needed
dependent packages.

Patch new ripgrep to understand the old bstr debug format in its tests.
This patch must be transitionnal while waiting for a compatible rust-bstr
package in Guix.

Disabling tests is bad. Disabling tests when we diverge from supported
upstream configuration (in this cas as we don't use recommended version
of deps) is in my opinion even worst.

François



  reply	other threads:[~2021-03-08 16:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-04 16:40 bug#46925: Ripgrep tests failures due to bstr update John Soo
2021-03-04 20:38 ` Nicolas Goaziou
2021-03-08 16:22   ` JOULAUD François via Bug reports for GNU Guix [this message]
2021-03-08 21:40     ` Nicolas Goaziou
2021-03-09 11:34       ` JOULAUD François via Bug reports for GNU Guix
2021-03-09 15:39       ` John Soo
2021-03-10 13:42         ` Nicolas Goaziou
2021-03-10 13:44           ` John Soo
2021-03-10 14:01             ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210308161856.rme6tdhbbr44zdev@fjo-extia-HPdeb.example.avalenn.eu \
    --to=bug-guix@gnu.org \
    --cc=46925@debbugs.gnu.org \
    --cc=Francois.JOULAUD@radiofrance.com \
    --cc=jsoo1@asu.edu \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).