unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Timothy Sample <samplet@ngyro.com>
To: guix-patches@gnu.org
Subject: bug#30680: [PATCH] Patch Racket to fix bug #30680
Date: Sun, 12 Aug 2018 14:25:11 -0400	[thread overview]
Message-ID: <87r2j3bfy0.fsf@ngyro.com> (raw)
In-Reply-To: <m1fu5is9ly.fsf@fastmail.net>

[-- Attachment #1: Type: text/plain, Size: 792 bytes --]

Hi Guix,

(Patch is attached below.)

This patch fixes <https://debbugs.gnu.org/30680>.  It does so by
patching Racket to treat store files specially.  I have verified that it
both fixes the bug above and still recompiles non-store files.

As far as I can tell, Racket only uses these checksums as part of its
“setup” library.  When deciding whether to use a bytecode file during
evaluation, it does not verify the checksum.  That’s why only the
“setup” code is patched.

As a side note, both GDB and Go have similar problems:

    • <https://debbugs.gnu.org/19973>
    • <https://debbugs.gnu.org/25752>

If there ever is a more general solution, this patch will no longer be
necessary.

(Also, Racket takes a bit of time to build, so reviewers beware!)


[-- Attachment #2: /home/samplet/code/guix-wip-racket/0001-gnu-racket-Ignore-bytecode-checksums-in-the-store.patch --]
[-- Type: message/external-body, Size: 102 bytes --]

[-- Attachment #3: Type: text/plain, Size: 8 bytes --]


-- Tim

  reply	other threads:[~2018-08-12 19:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-02 16:52 bug#30680: Installation of Racket packages tries to write to the store Konrad Hinsen
2018-08-12 18:25 ` Timothy Sample [this message]
2018-08-12 20:35   ` bug#30680: [PATCH] Patch Racket to fix bug #30680 Christopher Lemmer Webber
2018-08-12 20:51     ` Timothy Sample
2018-08-13 13:56       ` Konrad Hinsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2j3bfy0.fsf@ngyro.com \
    --to=samplet@ngyro.com \
    --cc=guix-patches@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).