From mboxrd@z Thu Jan  1 00:00:00 1970
From: Timothy Sample <samplet@ngyro.com>
Subject: bug#30680: [PATCH] Patch Racket to fix bug #30680
Date: Sun, 12 Aug 2018 14:25:11 -0400
Message-ID: <87r2j3bfy0.fsf@ngyro.com>
References: <m1fu5is9ly.fsf@fastmail.net>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46648)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fovjJ-0002a6-Fb
	for bug-guix@gnu.org; Sun, 12 Aug 2018 15:08:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fovjF-0000bz-CW
	for bug-guix@gnu.org; Sun, 12 Aug 2018 15:08:45 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:44003)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fovjF-0000bh-7Y
	for bug-guix@gnu.org; Sun, 12 Aug 2018 15:08:41 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fov3y-0000vk-8P
	for bug-guix@gnu.org; Sun, 12 Aug 2018 14:26:02 -0400
In-Reply-To: <m1fu5is9ly.fsf@fastmail.net>
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.30680.B.15340983343542@debbugs.gnu.org>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: guix-patches@gnu.org

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi Guix,

(Patch is attached below.)

This patch fixes <https://debbugs.gnu.org/30680>.  It does so by
patching Racket to treat store files specially.  I have verified that it
both fixes the bug above and still recompiles non-store files.

As far as I can tell, Racket only uses these checksums as part of its
=E2=80=9Csetup=E2=80=9D library.  When deciding whether to use a bytecode f=
ile during
evaluation, it does not verify the checksum.  That=E2=80=99s why only the
=E2=80=9Csetup=E2=80=9D code is patched.

As a side note, both GDB and Go have similar problems:

    =E2=80=A2 <https://debbugs.gnu.org/19973>
    =E2=80=A2 <https://debbugs.gnu.org/25752>

If there ever is a more general solution, this patch will no longer be
necessary.

(Also, Racket takes a bit of time to build, so reviewers beware!)


--=-=-=
Content-Type: message/external-body;
 name="/home/samplet/code/guix-wip-racket/0001-gnu-racket-Ignore-bytecode-checksums-in-the-store.patch";
 access-type=local-file

Content-Type: text/x-patch
Content-ID: <87pnynbfy0.fsf@ngyro.com>
Content-Transfer-Encoding: binary



--=-=-=
Content-Type: text/plain


-- Tim

--=-=-=--