unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Lemmer Webber <cwebber@dustycloud.org>
To: Timothy Sample <samplet@ngyro.com>
Cc: guix-patches@gnu.org
Subject: bug#30680: [PATCH] Patch Racket to fix bug #30680
Date: Sun, 12 Aug 2018 16:35:27 -0400	[thread overview]
Message-ID: <87lg9bfhm8.fsf@dustycloud.org> (raw)
In-Reply-To: <87r2j3bfy0.fsf@ngyro.com>

Timothy Sample writes:

> Hi Guix,
>
> (Patch is attached below.)
>
> This patch fixes <https://debbugs.gnu.org/30680>.  It does so by
> patching Racket to treat store files specially.  I have verified that it
> both fixes the bug above and still recompiles non-store files.
>
> As far as I can tell, Racket only uses these checksums as part of its
> “setup” library.  When deciding whether to use a bytecode file during
> evaluation, it does not verify the checksum.  That’s why only the
> “setup” code is patched.
>
> As a side note, both GDB and Go have similar problems:
>
>     • <https://debbugs.gnu.org/19973>
>     • <https://debbugs.gnu.org/25752>
>
> If there ever is a more general solution, this patch will no longer be
> necessary.
>
> (Also, Racket takes a bit of time to build, so reviewers beware!)
>
>
> -- Tim

Oh wait... it seems like the patch is not actually attached?  I assume
that must be an error!

Actually if I look at the raw view of the email I see:

--=-=-=
Content-Type: message/external-body;
 name="/home/samplet/code/guix-wip-racket/0001-gnu-racket-Ignore-bytecode-checksums-in-the-store.patch";
 access-type=local-file

Content-Type: text/x-patch
Content-ID: <87pnynbfy0.fsf@ngyro.com>
Content-Transfer-Encoding: binary



--=-=-=

So it looks like it should be attached, but I don't see the file
contents?

Perhaps this is an error on my end!  But I'm very eager to test this
patch!

  reply	other threads:[~2018-08-12 20:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-02 16:52 bug#30680: Installation of Racket packages tries to write to the store Konrad Hinsen
2018-08-12 18:25 ` bug#30680: [PATCH] Patch Racket to fix bug #30680 Timothy Sample
2018-08-12 20:35   ` Christopher Lemmer Webber [this message]
2018-08-12 20:51     ` Timothy Sample
2018-08-13 13:56       ` Konrad Hinsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lg9bfhm8.fsf@dustycloud.org \
    --to=cwebber@dustycloud.org \
    --cc=guix-patches@gnu.org \
    --cc=samplet@ngyro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).