From: Mark H Weaver <mhw@netris.org>
To: Maxime Devos <maximedevos@telenet.be>,
Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>,
51591@debbugs.gnu.org
Subject: bug#51591: webkitgtk fails to build on i686-linux; possibly a clang issue
Date: Sat, 06 Nov 2021 02:09:23 -0400 [thread overview]
Message-ID: <87r1btu85t.fsf@netris.org> (raw)
In-Reply-To: <f9d16b0d505e944a8954693aa37de1a68f6fb1bc.camel@telenet.be>
Hi Maxime,
Maxime Devos <maximedevos@telenet.be> writes:
> Mark H Weaver schreef op vr 05-11-2021 om 15:42 [-0400]:
>> + ;; XXX Until we switch back to using GCC,
>> + ;; work around <https://bugs.gnu.org/51591>.
>> + ,@(if (string=? "i686-linux" (%current-system))
>> + '((substitute*
>> "Source/WTF/wtf/CheckedArithmetic.h"
>> + (("#define USE_MUL_OVERFLOW 1")
>> + "#define USE_MUL_OVERFLOW 0")))
>> + '())
>
> For cross-compilation, this should use (%current-target-system)
> instead. Also, I'd presume the same issue exists for the Hurd.
> I'd suggest: (target-x86-32?). That procedure is not
> yet in master (only core-updates{-frozen{,-batched-changes}}),
> so it would need to be cherry picked.
You're certainly right that the simple test above is not a good example
of how best to check if we're building for i686-linux.
For that matter, a more proper fix would be the one I proposed in my
earlier email: to apply a patch to Source/WTF/wtf/CheckedArithmetic.h
that changes "CPU(ARM)" to "(CPU(ARM) || CPU(XXX))", where XXX is the
appropriate symbol for 32-bit x86. Such a patch could even be submitted
upstream. That's really the kind of approach I'd like to encourage.
In this case, I had very little available time to work on it, but wanted
to get the problem fixed on i686-linux ASAP. Given this, and the fact
that this code is a temporary workaround until the core-updates-frozen
merge, and also my assumption that we are quite far from being able to
usefully cross-compile WebKitGTK and its dependencies, I don't feel
*too* badly about cutting corners here.
Having said all of this, I certainly agree that the conditional above
should be changed to follow our best practices. Would you like to
propose a patch?
Thanks very much for your vigilance.
Regards,
Mark
--
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>.
next prev parent reply other threads:[~2021-11-06 6:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 18:25 bug#51591: webkitgtk fails to build on i686-linux; possibly a clang issue Mark H Weaver
2021-11-03 21:04 ` Mark H Weaver
2021-11-04 8:03 ` Liliana Marie Prikler
2021-11-04 23:15 ` Mark H Weaver
2021-11-05 8:08 ` Liliana Marie Prikler
2021-11-05 16:24 ` Leo Famulari
2021-11-05 19:16 ` Mark H Weaver
2021-11-05 19:42 ` Mark H Weaver
2021-11-05 20:11 ` Maxime Devos
2021-11-06 6:09 ` Mark H Weaver [this message]
2021-11-07 5:46 ` Mark H Weaver
2021-11-06 7:34 ` Mark H Weaver
2021-11-05 2:38 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1btu85t.fsf@netris.org \
--to=mhw@netris.org \
--cc=51591@debbugs.gnu.org \
--cc=liliana.prikler@ist.tugraz.at \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).