unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: Maxime Devos <maximedevos@telenet.be>,
	Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>,
	51591@debbugs.gnu.org
Subject: bug#51591: webkitgtk fails to build on i686-linux; possibly a clang issue
Date: Sun, 07 Nov 2021 01:46:28 -0400	[thread overview]
Message-ID: <87r1bsy0ts.fsf@netris.org> (raw)
In-Reply-To: <87r1btu85t.fsf@netris.org>

Hi Maxime,

Earlier, I wrote:
> Having said all of this, I certainly agree that the conditional above
> should be changed to follow our best practices.  Would you like to
> propose a patch?

I went ahead and cherry-picked your 'target-x86-32?' and 'target-x86-64?'
predicates to 'master' in commit b0519cc4b04d29ea9327a117eb6c8c21547e6159,
and then improved the suboptimal check to use 'target-x86-32?', in commit
b11badfb4cd8124f2f467697cf2a4d15e7f20b19.

     Thanks,
       Mark

-- 
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>.




  reply	other threads:[~2021-11-07  5:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 18:25 bug#51591: webkitgtk fails to build on i686-linux; possibly a clang issue Mark H Weaver
2021-11-03 21:04 ` Mark H Weaver
2021-11-04  8:03   ` Liliana Marie Prikler
2021-11-04 23:15     ` Mark H Weaver
2021-11-05  8:08       ` Liliana Marie Prikler
2021-11-05 16:24         ` Leo Famulari
2021-11-05 19:16           ` Mark H Weaver
2021-11-05 19:42         ` Mark H Weaver
2021-11-05 20:11           ` Maxime Devos
2021-11-06  6:09             ` Mark H Weaver
2021-11-07  5:46               ` Mark H Weaver [this message]
2021-11-06  7:34           ` Mark H Weaver
2021-11-05  2:38   ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1bsy0ts.fsf@netris.org \
    --to=mhw@netris.org \
    --cc=51591@debbugs.gnu.org \
    --cc=liliana.prikler@ist.tugraz.at \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).