From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uCLDDM8chmFYogAAgWs5BA (envelope-from ) for ; Sat, 06 Nov 2021 07:12:31 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id SGN5CM8chmHuWQAA1q6Kng (envelope-from ) for ; Sat, 06 Nov 2021 06:12:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A0BB32A766 for ; Sat, 6 Nov 2021 07:12:30 +0100 (CET) Received: from localhost ([::1]:43404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjEwH-0008RF-Jj for larch@yhetil.org; Sat, 06 Nov 2021 02:12:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44892) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjEvq-0008Qu-QV for bug-guix@gnu.org; Sat, 06 Nov 2021 02:12:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36600) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjEvq-0004En-IB for bug-guix@gnu.org; Sat, 06 Nov 2021 02:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjEvq-0003Zu-Cz for bug-guix@gnu.org; Sat, 06 Nov 2021 02:12:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#51591: webkitgtk fails to build on i686-linux; possibly a clang issue Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 06 Nov 2021 06:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51591 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxime Devos , Liliana Marie Prikler , 51591@debbugs.gnu.org Received: via spool by 51591-submit@debbugs.gnu.org id=B51591.163617909413719 (code B ref 51591); Sat, 06 Nov 2021 06:12:02 +0000 Received: (at 51591) by debbugs.gnu.org; 6 Nov 2021 06:11:34 +0000 Received: from localhost ([127.0.0.1]:48146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjEvN-0003ZD-NX for submit@debbugs.gnu.org; Sat, 06 Nov 2021 02:11:33 -0400 Received: from world.peace.net ([64.112.178.59]:33712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjEvL-0003Yz-FC for 51591@debbugs.gnu.org; Sat, 06 Nov 2021 02:11:32 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjEvE-0006fk-RA; Sat, 06 Nov 2021 02:11:24 -0400 From: Mark H Weaver In-Reply-To: References: <875yt9m6ye.fsf@netris.org> <871r3xlzlu.fsf@netris.org> <87lf23v7fg.fsf@netris.org> <9dd1626d19a68eb6ff1f51d1324692c7801b1ee7.camel@ist.tugraz.at> <878ry2v15x.fsf@netris.org> Date: Sat, 06 Nov 2021 02:09:23 -0400 Message-ID: <87r1btu85t.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636179151; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=ERHGjmisKZyOleyAe1NC6/o32gt6qiPoCkMfgRpcanE=; b=OcBvCufTT58V7RqIsX4LA4XaP2GMOJbPha8fugAXQxUoT6O29c/UhDwH1YnwPjAyZUgRiw pkyN4sdUZjCje6EKM98p7hSwyBQiNGEcSVHA7NE/Sf8f63I6IOJUWdmnE15uBruSfb8t77 Kev96QvFObcYk5eMtYVevcRUCjqgioM/UggrRWfEv+1QzBZoXNBhl0D/Uy+yLI0icA+/NM w7zpZhcamXWL7yGU4JwNKCXZeA4lPKEOOgptCTlpB8O43urg1ByyKq3EEjJKuvOBNqW3RK X11T2AIq/kzlwdERlarcofqgBXs95eXVnyaBLRV555dSBqSJtjC62Zce9eDzOQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636179151; a=rsa-sha256; cv=none; b=tN1Wrib4vdrbsa6Yu3CMsI4CBL9G6uukvdvCMu1xJwWrbYt+Zr3Ez6QzqbLuosNnkeDCBW H8kUOjw6X1/bIx2Z1go1Ps6AtkJrRVl31G+xm035pTU+cXlvyulG+21R+dQ/8pGU87sh5Q tznlboLbn7M2j39604WM9Ei4UkMymStonl94HHOLSIQ5RdRso27M9zQ5PrZ8FEB3mKOtpM SfHoPEC+SDR+YKygVCEKRkhKHjcCL7NTLRoZPlfNJ63RKppe+PBThMr3aHhlxEb4apCPOa jbo9PAommN0AvNtbcnPyI1nDDtppxM+xGslQZIPQpn5TyJZ2OsLIkcaEZ5/Ggg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -2.42 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: A0BB32A766 X-Spam-Score: -2.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: nB4rcapjR/Oc Hi Maxime, Maxime Devos writes: > Mark H Weaver schreef op vr 05-11-2021 om 15:42 [-0400]: >> + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; = XXX Until we switch back to using GCC, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 ;; work around . >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 ,@(if (string=3D? "i686-linux" (%current-system)) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 '((substitute* >> "Source/WTF/wtf/CheckedArithmetic.h" >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (("#define = USE_MUL_OVERFLOW 1") >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "#def= ine USE_MUL_OVERFLOW 0"))) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 '()) > > For cross-compilation, this should use (%current-target-system) > instead. Also, I'd presume the same issue exists for the Hurd. > I'd suggest: (target-x86-32?). That procedure is not > yet in master (only core-updates{-frozen{,-batched-changes}}), > so it would need to be cherry picked. You're certainly right that the simple test above is not a good example of how best to check if we're building for i686-linux. For that matter, a more proper fix would be the one I proposed in my earlier email: to apply a patch to Source/WTF/wtf/CheckedArithmetic.h that changes "CPU(ARM)" to "(CPU(ARM) || CPU(XXX))", where XXX is the appropriate symbol for 32-bit x86. Such a patch could even be submitted upstream. That's really the kind of approach I'd like to encourage. In this case, I had very little available time to work on it, but wanted to get the problem fixed on i686-linux ASAP. Given this, and the fact that this code is a temporary workaround until the core-updates-frozen merge, and also my assumption that we are quite far from being able to usefully cross-compile WebKitGTK and its dependencies, I don't feel *too* badly about cutting corners here. Having said all of this, I certainly agree that the conditional above should be changed to follow our best practices. Would you like to propose a patch? Thanks very much for your vigilance. Regards, Mark --=20 Disinformation flourishes because many people care deeply about injustice but very few check the facts. Ask me about .