* bug#33586: "updating substitutes" spam
@ 2018-12-02 13:09 Taylan Kammer
2018-12-04 7:00 ` Ricardo Wurmus
0 siblings, 1 reply; 4+ messages in thread
From: Taylan Kammer @ 2018-12-02 13:09 UTC (permalink / raw)
To: 33586
A minor issue, but I wanted to create a bug-report for this to make
sure it's on the radar.
During updates, guix may print this message hundreds of times:
substitute: updating substitutes from 'http://...' 100%
Repetitions of this message should probably be coalesced into a single
message.
- Taylan
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#33586: "updating substitutes" spam
2018-12-02 13:09 bug#33586: "updating substitutes" spam Taylan Kammer
@ 2018-12-04 7:00 ` Ricardo Wurmus
2018-12-04 14:20 ` Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Ricardo Wurmus @ 2018-12-04 7:00 UTC (permalink / raw)
To: Taylan Kammer; +Cc: 33586
Taylan Kammer <taylan.kammer@gmail.com> writes:
> A minor issue, but I wanted to create a bug-report for this to make
> sure it's on the radar.
>
> During updates, guix may print this message hundreds of times:
>
> substitute: updating substitutes from 'http://...' 100%
>
> Repetitions of this message should probably be coalesced into a single
> message.
Each of these messages is for a different substitute query. We are
currently not showing the query, so it looks like the same work is done
multiple times.
The substitute queries are executed at different times. Coalescing the
messages would mean that the messages for previous queries are delayed
until the last query is performed. This would not be good.
I don’t know if we can reorder the queries so that they all happen at
once.
--
Ricardo
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#33586: "updating substitutes" spam
2018-12-04 7:00 ` Ricardo Wurmus
@ 2018-12-04 14:20 ` Ludovic Courtès
2020-07-14 22:17 ` Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2018-12-04 14:20 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: 33586
Ricardo Wurmus <rekado@elephly.net> skribis:
> Taylan Kammer <taylan.kammer@gmail.com> writes:
>
>> A minor issue, but I wanted to create a bug-report for this to make
>> sure it's on the radar.
>>
>> During updates, guix may print this message hundreds of times:
>>
>> substitute: updating substitutes from 'http://...' 100%
>>
>> Repetitions of this message should probably be coalesced into a single
>> message.
>
> Each of these messages is for a different substitute query. We are
> currently not showing the query, so it looks like the same work is done
> multiple times.
>
> The substitute queries are executed at different times. Coalescing the
> messages would mean that the messages for previous queries are delayed
> until the last query is performed. This would not be good.
>
> I don’t know if we can reorder the queries so that they all happen at
> once.
In the absence of grafts, the system is designed to perform all the
substitute queries at once (with HTTP pipelining and all.) So you see
only one message.
However, the current implementation of grafts relies on substitutes
(when enabled) to determine whether a given package should be grafted.
Due to the way this is implemented, the resulted queries are not
coalesced, leading to these messages and, more importantly, poor network
usage (no pipelining, no connection reuse, etc.)
This is really a shortcoming of the current implementation of grafts,
much as discussed in <https://issues.guix.info/issue/28310>.
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-14 22:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-02 13:09 bug#33586: "updating substitutes" spam Taylan Kammer
2018-12-04 7:00 ` Ricardo Wurmus
2018-12-04 14:20 ` Ludovic Courtès
2020-07-14 22:17 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).