unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#54723: [PATCH] Check URI when verifying narinfo validity.
       [not found]                     ` <87y1zn6ev5.fsf_-_@gnu.org>
@ 2022-04-29 21:16                       ` Ludovic Courtès
  2022-04-30 12:12                         ` Guillaume Le Vaillant
  2022-04-30 12:15                       ` Mathieu Othacehe
  1 sibling, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2022-04-29 21:16 UTC (permalink / raw)
  To: Guillaume Le Vaillant; +Cc: Mathieu Othacehe, 54723

Ludovic Courtès <ludo@gnu.org> skribis:

> So in commit c1719a0adf3fa7611b56ca4d75b3ac8cf5c9c8ac I went ahead and
> reverted it that commit.  I also added a test that reproduces the issue
> above.

Commit 9eca13094d9bdf091f9096e0f3a8b450dac0e595 updates the ‘guix’
package, so you can now pull, reconfigure, and enjoy.  :-)

Ludo’.




^ permalink raw reply	[flat|nested] 4+ messages in thread
* bug#54723: [PATCH] Check URI when verifying narinfo validity.
  2022-04-29 21:16                       ` bug#54723: [PATCH] Check URI when verifying narinfo validity Ludovic Courtès
@ 2022-04-30 12:12                         ` Guillaume Le Vaillant
  0 siblings, 0 replies; 4+ messages in thread
From: Guillaume Le Vaillant @ 2022-04-30 12:12 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: Mathieu Othacehe, 54723

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

Ludovic Courtès <ludo@gnu.org> skribis:

> Ludovic Courtès <ludo@gnu.org> skribis:
>
>> So in commit c1719a0adf3fa7611b56ca4d75b3ac8cf5c9c8ac I went ahead and
>> reverted it that commit.  I also added a test that reproduces the issue
>> above.
>
> Commit 9eca13094d9bdf091f9096e0f3a8b450dac0e595 updates the ‘guix’
> package, so you can now pull, reconfigure, and enjoy.  :-)
>
> Ludo’.

I just tried and everything worked without a glitch.
Thanks.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
* bug#54723: [PATCH] Check URI when verifying narinfo validity.
       [not found]                     ` <87y1zn6ev5.fsf_-_@gnu.org>
  2022-04-29 21:16                       ` bug#54723: [PATCH] Check URI when verifying narinfo validity Ludovic Courtès
@ 2022-04-30 12:15                       ` Mathieu Othacehe
  2022-05-01 13:12                         ` Ludovic Courtès
  1 sibling, 1 reply; 4+ messages in thread
From: Mathieu Othacehe @ 2022-04-30 12:15 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 54723


Hey Ludo,

> Now, the only way ‘narinfo-string’ can take too long these days is (I
> think) if the store GC lock is held (we should check that hypothesis,
> but I believe that if the GC lock is held, then the ‘query-path-info’
> RPC made from ‘narinfo-string’ might block until the lock is released).
> The GC lock is no longer held for hours on berlin, so there’s less
> pressure to address that.

Thanks for having a look to that issue. On my side, I'd like to take
some time to look closely at the situation.

> To summarize: I think ‘guix publish’ is okay as-is but we should
> fiberize it sometime.

I think however that it would be nice to create a wip branch for those
changes, deploy it and monitor it closely on Berlin before pushing. From
experience, the publish code is really fragile and the I/O pressure on
Berlin can exhibit a lot of unexpected issues.

Mathieu




^ permalink raw reply	[flat|nested] 4+ messages in thread
* bug#54723: [PATCH] Check URI when verifying narinfo validity.
  2022-04-30 12:15                       ` Mathieu Othacehe
@ 2022-05-01 13:12                         ` Ludovic Courtès
  0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2022-05-01 13:12 UTC (permalink / raw)
  To: Mathieu Othacehe; +Cc: 54723

Hi,

Mathieu Othacehe <othacehe@gnu.org> skribis:

> I think however that it would be nice to create a wip branch for those
> changes, deploy it and monitor it closely on Berlin before pushing. From
> experience, the publish code is really fragile and the I/O pressure on
> Berlin can exhibit a lot of unexpected issues.

Agreed, it looks like we have to be more cautious now.

Ludo’.




^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-01 13:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <87a6czbzvh.fsf@kitej>
     [not found] ` <877d83lapv.fsf@gnu.org>
     [not found]   ` <875ynnbe65.fsf@kitej>
     [not found]     ` <87pmlq6lqx.fsf_-_@gnu.org>
     [not found]       ` <877d7ydjwk.fsf@kitej>
     [not found]         ` <87wnfv90cl.fsf@kitej>
     [not found]           ` <871qy2g2v3.fsf@gnu.org>
     [not found]             ` <87o816wt36.fsf@kitej>
     [not found]               ` <87sfqfc0fq.fsf@kitej>
     [not found]                 ` <87bkwyxjtp.fsf@gnu.org>
     [not found]                   ` <87v8v3ddz5.fsf@kitej>
     [not found]                     ` <87y1zn6ev5.fsf_-_@gnu.org>
2022-04-29 21:16                       ` bug#54723: [PATCH] Check URI when verifying narinfo validity Ludovic Courtès
2022-04-30 12:12                         ` Guillaume Le Vaillant
2022-04-30 12:15                       ` Mathieu Othacehe
2022-05-01 13:12                         ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).