unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 54723@debbugs.gnu.org
Subject: bug#54723: [PATCH] Check URI when verifying narinfo validity.
Date: Sat, 30 Apr 2022 14:15:31 +0200	[thread overview]
Message-ID: <87ilqqwyvw.fsf@gnu.org> (raw)
In-Reply-To: <87y1zn6ev5.fsf_-_@gnu.org> ("Ludovic Courtès"'s message of "Fri, 29 Apr 2022 18:20:14 +0200")


Hey Ludo,

> Now, the only way ‘narinfo-string’ can take too long these days is (I
> think) if the store GC lock is held (we should check that hypothesis,
> but I believe that if the GC lock is held, then the ‘query-path-info’
> RPC made from ‘narinfo-string’ might block until the lock is released).
> The GC lock is no longer held for hours on berlin, so there’s less
> pressure to address that.

Thanks for having a look to that issue. On my side, I'd like to take
some time to look closely at the situation.

> To summarize: I think ‘guix publish’ is okay as-is but we should
> fiberize it sometime.

I think however that it would be nice to create a wip branch for those
changes, deploy it and monitor it closely on Berlin before pushing. From
experience, the publish code is really fragile and the I/O pressure on
Berlin can exhibit a lot of unexpected issues.

Mathieu




  parent reply	other threads:[~2022-04-30 12:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87a6czbzvh.fsf@kitej>
     [not found] ` <877d83lapv.fsf@gnu.org>
     [not found]   ` <875ynnbe65.fsf@kitej>
     [not found]     ` <87pmlq6lqx.fsf_-_@gnu.org>
     [not found]       ` <877d7ydjwk.fsf@kitej>
     [not found]         ` <87wnfv90cl.fsf@kitej>
     [not found]           ` <871qy2g2v3.fsf@gnu.org>
     [not found]             ` <87o816wt36.fsf@kitej>
     [not found]               ` <87sfqfc0fq.fsf@kitej>
     [not found]                 ` <87bkwyxjtp.fsf@gnu.org>
     [not found]                   ` <87v8v3ddz5.fsf@kitej>
     [not found]                     ` <87y1zn6ev5.fsf_-_@gnu.org>
2022-04-29 21:16                       ` bug#54723: [PATCH] Check URI when verifying narinfo validity Ludovic Courtès
2022-04-30 12:12                         ` Guillaume Le Vaillant
2022-04-30 12:15                       ` Mathieu Othacehe [this message]
2022-05-01 13:12                         ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilqqwyvw.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=54723@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).