* bug#22004: guix-environment-container.sh test fails when building guix on tmpfs
@ 2015-11-24 15:57 Ting-Wei Lan
2016-07-31 16:54 ` Ludovic Courtès
2016-08-01 4:43 ` Ting-Wei Lan
0 siblings, 2 replies; 6+ messages in thread
From: Ting-Wei Lan @ 2015-11-24 15:57 UTC (permalink / raw)
To: 22004
This problem happens on both guix 0.9.0 and master branch.
$tmpdir/mounts can be empty when running tests on tmpfs because
$mount_test_code ignores tmpfs. (`wc -l $tmpdir/mounts` is 0)
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#22004: guix-environment-container.sh test fails when building guix on tmpfs
2015-11-24 15:57 bug#22004: guix-environment-container.sh test fails when building guix on tmpfs Ting-Wei Lan
@ 2016-07-31 16:54 ` Ludovic Courtès
2016-08-01 4:43 ` Ting-Wei Lan
1 sibling, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2016-07-31 16:54 UTC (permalink / raw)
To: Ting-Wei Lan; +Cc: 22004-done
Hello,
Ting-Wei Lan <lantw44@gmail.com> skribis:
> This problem happens on both guix 0.9.0 and master branch.
>
> $tmpdir/mounts can be empty when running tests on tmpfs because
> $mount_test_code ignores tmpfs. (`wc -l $tmpdir/mounts` is 0)
Indeed; I believe commit 1250034d5aff14fe236aad9900233a2b6f8563bb fixes
it.
Sorry for not coming back to you earlier! Somehow this report didn’t
show up on our radar.
Thank you!
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#22004: guix-environment-container.sh test fails when building guix on tmpfs
2015-11-24 15:57 bug#22004: guix-environment-container.sh test fails when building guix on tmpfs Ting-Wei Lan
2016-07-31 16:54 ` Ludovic Courtès
@ 2016-08-01 4:43 ` Ting-Wei Lan
2016-08-01 13:13 ` Ludovic Courtès
1 sibling, 1 reply; 6+ messages in thread
From: Ting-Wei Lan @ 2016-08-01 4:43 UTC (permalink / raw)
To: 22004
I ran the test on core-updates branch, but it still failed.
Output in tests/guix-environment-container.log:
+ cat t-guix-environment-31068/mounts
/path/to/a/tmpfs/mountpoint/guix-build
++ wc -l
+ test 1 -eq 4
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#22004: guix-environment-container.sh test fails when building guix on tmpfs
2016-08-01 4:43 ` Ting-Wei Lan
@ 2016-08-01 13:13 ` Ludovic Courtès
2016-08-24 8:39 ` Ting-Wei Lan
0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2016-08-01 13:13 UTC (permalink / raw)
To: Ting-Wei Lan; +Cc: 22004
Hi,
Ting-Wei Lan <lantw44@gmail.com> skribis:
> I ran the test on core-updates branch, but it still failed.
>
> Output in tests/guix-environment-container.log:
>
> + cat t-guix-environment-31068/mounts
> /path/to/a/tmpfs/mountpoint/guix-build
> ++ wc -l
> + test 1 -eq 4
I’m at loss; on my machine I see:
--8<---------------cut here---------------start------------->8---
+ cat t-guix-environment-18663/mounts
/home/ludo/src/guix
/home/ludo/src/guix/test-tmp/store/h0sb9ww7hzqcfnyiar5102amdzxm5hvy-bash
/home/ludo/src/guix/test-tmp/store/p7j32xzhdkd1h13d8kh1qw3jq7vbdbkp-guile-bootstrap-2.0
/home/ludo/src/guix/test-tmp/store/vqrqdk62gjyca4isl7qq5d0zxanwl5va-profile
--8<---------------cut here---------------end--------------->8---
Any idea what happens to the 3
/path/to/a/tmpfs/mountpoint/guix-build/test-tmp entries on your system?
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#22004: guix-environment-container.sh test fails when building guix on tmpfs
2016-08-01 13:13 ` Ludovic Courtès
@ 2016-08-24 8:39 ` Ting-Wei Lan
2016-08-28 14:05 ` Ludovic Courtès
0 siblings, 1 reply; 6+ messages in thread
From: Ting-Wei Lan @ 2016-08-24 8:39 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 22004
於 週一，2016-08-01 於 15:13 +0200，Ludovic Courtès 提到：
> Hi,
>
> Ting-Wei Lan <lantw44@gmail.com> skribis:
>
> >
> > I ran the test on core-updates branch, but it still failed.
> >
> > Output in tests/guix-environment-container.log:
> >
> > + cat t-guix-environment-31068/mounts
> > /path/to/a/tmpfs/mountpoint/guix-build
> > ++ wc -l
> > + test 1 -eq 4
>
> I’m at loss; on my machine I see:
>
> --8<---------------cut here---------------start------------->8---
> + cat t-guix-environment-18663/mounts
> /home/ludo/src/guix
> /home/ludo/src/guix/test-tmp/store/h0sb9ww7hzqcfnyiar5102amdzxm5hvy-
> bash
> /home/ludo/src/guix/test-tmp/store/p7j32xzhdkd1h13d8kh1qw3jq7vbdbkp-
> guile-bootstrap-2.0
> /home/ludo/src/guix/test-tmp/store/vqrqdk62gjyca4isl7qq5d0zxanwl5va-
> profile
> --8<---------------cut here---------------end--------------->8---
>
> Any idea what happens to the 3
> /path/to/a/tmpfs/mountpoint/guix-build/test-tmp entries on your
> system?
They are on tmpfs and the order of the two arguments of 'string-
prefix?' function seems to be wrong, so these 3 entries are ignored.
A simple fix:
diff --git a/tests/guix-environment-container.sh b/tests/guix-environment-container.sh
index 12da950..d7c1b70 100644
--- a/tests/guix-environment-container.sh
+++ b/tests/guix-environment-container.sh
@@ -72,7 +72,7 @@ mount_test_code="
;; correspond to a parent file system.
((_ mount (or \"tmpfs\" \"proc\" \"sysfs\" \"devtmpfs\"
\"devpts\" \"cgroup\" \"mqueue\") _ _ _)
- (and (string-prefix? mount (getcwd))
+ (and (string-prefix? (getcwd) mount)
mount))
((_ mount _ _ _ _)
mount)))
After changing the order, guix-environment-container.sh passes.
>
> Thanks,
> Ludo’.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#22004: guix-environment-container.sh test fails when building guix on tmpfs
2016-08-24 8:39 ` Ting-Wei Lan
@ 2016-08-28 14:05 ` Ludovic Courtès
0 siblings, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2016-08-28 14:05 UTC (permalink / raw)
To: Ting-Wei Lan; +Cc: 22004-done
Ting-Wei Lan <lantw44@gmail.com> skribis:
> They are on tmpfs and the order of the two arguments of 'string-
> prefix?' function seems to be wrong, so these 3 entries are ignored.
>
> A simple fix:
>
> diff --git a/tests/guix-environment-container.sh b/tests/guix-environment-container.sh
> index 12da950..d7c1b70 100644
> --- a/tests/guix-environment-container.sh
> +++ b/tests/guix-environment-container.sh
> @@ -72,7 +72,7 @@ mount_test_code="
> ;; correspond to a parent file system.
> ((_ mount (or \"tmpfs\" \"proc\" \"sysfs\" \"devtmpfs\"
> \"devpts\" \"cgroup\" \"mqueue\") _ _ _)
> - (and (string-prefix? mount (getcwd))
> + (and (string-prefix? (getcwd) mount)
> mount))
> ((_ mount _ _ _ _)
> mount)))
>
> After changing the order, guix-environment-container.sh passes.
Good catch! Applied, thanks!
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-28 14:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-24 15:57 bug#22004: guix-environment-container.sh test fails when building guix on tmpfs Ting-Wei Lan
2016-07-31 16:54 ` Ludovic Courtès
2016-08-01 4:43 ` Ting-Wei Lan
2016-08-01 13:13 ` Ludovic Courtès
2016-08-24 8:39 ` Ting-Wei Lan
2016-08-28 14:05 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).