From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ting-Wei Lan <lantw44@gmail.com>
Subject: bug#22004: guix-environment-container.sh test fails when building
	guix on tmpfs
Date: Wed, 24 Aug 2016 16:39:00 +0800
Message-ID: <1472027940.26857.5.camel@gmail.com>
References: <1448380659.15506.20.camel@gmail.com>
	<1470026589.19967.3.camel@gmail.com> <871t28skc6.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40143)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1bcTjE-0006Ah-Ey
	for bug-guix@gnu.org; Wed, 24 Aug 2016 04:40:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1bcTj8-00054W-FQ
	for bug-guix@gnu.org; Wed, 24 Aug 2016 04:40:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:40932)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1bcTj8-00054P-BU
	for bug-guix@gnu.org; Wed, 24 Aug 2016 04:40:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1bcTj7-0005FI-V4
	for bug-guix@gnu.org; Wed, 24 Aug 2016 04:40:01 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.22004.B22004.147202795220092@debbugs.gnu.org>
In-Reply-To: <871t28skc6.fsf@gnu.org>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 22004@debbugs.gnu.org

於 週一，2016-08-01 於 15:13 +0200，Ludovic Courtès 提到：
> Hi,
> 
> Ting-Wei Lan <lantw44@gmail.com> skribis:
> 
> > 
> > I ran the test on core-updates branch, but it still failed.
> > 
> > Output in tests/guix-environment-container.log:
> > 
> > + cat t-guix-environment-31068/mounts
> > /path/to/a/tmpfs/mountpoint/guix-build
> > ++ wc -l
> > + test 1 -eq 4
> 
> I’m at loss; on my machine I see:
> 
> --8<---------------cut here---------------start------------->8---
> + cat t-guix-environment-18663/mounts
> /home/ludo/src/guix
> /home/ludo/src/guix/test-tmp/store/h0sb9ww7hzqcfnyiar5102amdzxm5hvy-
> bash
> /home/ludo/src/guix/test-tmp/store/p7j32xzhdkd1h13d8kh1qw3jq7vbdbkp-
> guile-bootstrap-2.0
> /home/ludo/src/guix/test-tmp/store/vqrqdk62gjyca4isl7qq5d0zxanwl5va-
> profile
> --8<---------------cut here---------------end--------------->8---
> 
> Any idea what happens to the 3
> /path/to/a/tmpfs/mountpoint/guix-build/test-tmp entries on your
> system?

They are on tmpfs and the order of the two arguments of 'string-
prefix?' function seems to be wrong, so these 3 entries are ignored.

A simple fix:

diff --git a/tests/guix-environment-container.sh b/tests/guix-environment-container.sh
index 12da950..d7c1b70 100644
--- a/tests/guix-environment-container.sh
+++ b/tests/guix-environment-container.sh
@@ -72,7 +72,7 @@ mount_test_code="
                   ;; correspond to a parent file system.
                   ((_ mount (or \"tmpfs\" \"proc\" \"sysfs\" \"devtmpfs\"
                                 \"devpts\" \"cgroup\" \"mqueue\") _ _ _)
-                   (and (string-prefix? mount (getcwd))
+                   (and (string-prefix? (getcwd) mount)
 		        mount))
                   ((_ mount _ _ _ _)
                    mount)))

After changing the order, guix-environment-container.sh passes.

> 
> Thanks,
> Ludo’.