From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: bug#27222: [PATCH] emacs-build-system install phase doesn't honor directory hierarchy Date: Mon, 05 Jun 2017 23:07:52 +0300 Message-ID: <87o9u2kxk7.fsf@gmail.com> References: <87h8zwptdn.fsf@gmail.com> <874lvwp7km.fsf@gmail.com> <87wp8rq57k.fsf@gmail.com> <0efe58d4.AEUAK47aAUsAAAAAAAAAAAO2CsUAAAACwQwAAAAAAAW9WABZNF6l@mailjet.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHyIG-00088z-QX for bug-guix@gnu.org; Mon, 05 Jun 2017 16:08:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHyIE-0003z2-3Q for bug-guix@gnu.org; Mon, 05 Jun 2017 16:08:04 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55424) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dHyIE-0003yn-0H for bug-guix@gnu.org; Mon, 05 Jun 2017 16:08:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dHyID-0003uv-R3 for bug-guix@gnu.org; Mon, 05 Jun 2017 16:08:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <0efe58d4.AEUAK47aAUsAAAAAAAAAAAO2CsUAAAACwQwAAAAAAAW9WABZNF6l@mailjet.com> (Arun Isaac's message of "Mon, 05 Jun 2017 00:55:11 +0530") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Arun Isaac Cc: Maxim Cournoyer , 27222@debbugs.gnu.org Arun Isaac (2017-06-05 00:55 +0530) wrote: [...] >> I also think these arguments are redundant! I suggested to remove this >> duplication at: >> >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26559#41 > > And, I did respond at > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26559#53 Sure, I didn't mean I was ignored, I just wanted to say that I got the same thought about those arguments as Maxim. >> ... but I think the include/exclude arguments need to be duplicated in >> two places. For example, look at arguments #:strip-flags and >> #:strip-directories in the `strip' phase of the gnu-build-system. Even >> there, the default values of the arguments are repeated in two places. > > Do you know of some way in which we can avoid duplication of the > arguments? As I said, I think this duplication can be avoided simply by removing the values of 'include'/'exclude' arguments from 'install' procedures of (guix build emacs-build-system) module. > Even the gnu-build-system duplicates default values of arguments. I don't know about gnu-build-system, but I don't see a reason to have these values in 'install' procedure of emacs-build-system. -- Alex