From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 56297@debbugs.gnu.org
Subject: bug#56297: Guix style imperfections
Date: Mon, 04 Jul 2022 23:41:40 +0200 [thread overview]
Message-ID: <87mtdo7dyj.fsf@gnu.org> (raw)
In-Reply-To: <87sfnj259y.fsf@gnu.org> ("Ludovic Courtès"'s message of "Sat, 02 Jul 2022 12:11:21 +0200")
Hi,
Ludovic Courtès <ludo@gnu.org> skribis:
>>> (define-public guile-next
>>> (let ((version "3.0.7") (revision "0")
>>> (commit "d70c1dbebf9ac0fd45af4578c23983ec4a7da535"))
>>
>> Conventionally 'revision' is put on another line -- for these kind of let bindings,
>> (maybe all?), I would recommend to put all of them on separate lines.
>
> This one is a bug IMO: ‘let’ bindings should be treated specially, and
> currently they’re not.
Commit 8d9291bd2c36810be50ea340cefa481a42c60a2b fixes this, and…
>>> (substitute-keyword-arguments (package-arguments guile-3.0)
>>> ((#:phases phases
>>> '%standard-phases) `(modify-phases ,phases
>>
>> Put %standard-phases on the same line ad #:phases phases and `(modify-phases ,phases
>> on a new lineg
… the second part of this one.
Ludo’.
next prev parent reply other threads:[~2022-07-04 21:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 9:33 bug#56297: Guix style imperfections Maxime Devos
2022-06-29 10:15 ` Liliana Marie Prikler
2022-06-29 10:18 ` Maxime Devos
2022-06-29 10:20 ` Liliana Marie Prikler
2022-06-29 10:19 ` Maxime Devos
2022-06-29 10:25 ` Liliana Marie Prikler
2022-07-02 10:11 ` Ludovic Courtès
2022-07-04 21:41 ` Ludovic Courtès [this message]
2022-07-19 13:40 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtdo7dyj.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=56297@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).