From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4ABBLrRew2KuNwEAbAwnHQ (envelope-from ) for ; Mon, 04 Jul 2022 23:42:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mJYqLrRew2L5XAEAauVa8A (envelope-from ) for ; Mon, 04 Jul 2022 23:42:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7493125754 for ; Mon, 4 Jul 2022 23:42:12 +0200 (CEST) Received: from localhost ([::1]:35536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8Tpb-0001jc-GT for larch@yhetil.org; Mon, 04 Jul 2022 17:42:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8TpS-0001jQ-VZ for bug-guix@gnu.org; Mon, 04 Jul 2022 17:42:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54875) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8TpS-000773-KN for bug-guix@gnu.org; Mon, 04 Jul 2022 17:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o8TpS-0002aZ-I3 for bug-guix@gnu.org; Mon, 04 Jul 2022 17:42:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#56297: Guix style imperfections Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 04 Jul 2022 21:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56297 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxime Devos Cc: 56297@debbugs.gnu.org Received: via spool by 56297-submit@debbugs.gnu.org id=B56297.16569709109929 (code B ref 56297); Mon, 04 Jul 2022 21:42:02 +0000 Received: (at 56297) by debbugs.gnu.org; 4 Jul 2022 21:41:50 +0000 Received: from localhost ([127.0.0.1]:48772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8TpF-0002a4-Tk for submit@debbugs.gnu.org; Mon, 04 Jul 2022 17:41:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8TpE-0002Zq-IT for 56297@debbugs.gnu.org; Mon, 04 Jul 2022 17:41:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8Tp9-00072B-8W; Mon, 04 Jul 2022 17:41:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=k/nR/qCRx0ZFNOGKrTNsgXQn+8HRD6XGsJvWOkxPKdY=; b=cupwe1Q+tkDgGZnyIDB0 BRrB6h2Sce/j6wXsGJgUehFxnv8KKEGQXKBmJbcmlDTcl0whO/qp75L4Hvbgy5im6h5ZrmjZCfuRB xmFg81QfhazG6QwGYKiMco42zuJCpXa5+DcDAUH5a784FYA5ZCkRCvy93OSq5zmU7fLDtXtZyi0px wkmDkbo/CenMFrGv5yUvRDQqqC+z/K0Owc2ZVtzsNf+X8LApnJz8xqU3ZJtBMBT6Lb06c+Llz8d3m 8nbuI8KTinmvvwgdZcD2O2bW62LAnIJDdRh2Zg5h5KHiNNz/bdYqUcKLqLTrhGmANNzvq2CNsnJ4b gYhiS/pNhT05bA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:54762 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8Tp8-0003hG-S9; Mon, 04 Jul 2022 17:41:43 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <9499300db3fe4222f7126240fb2acad3cdf4371b.camel@telenet.be> <87sfnj259y.fsf@gnu.org> Date: Mon, 04 Jul 2022 23:41:40 +0200 In-Reply-To: <87sfnj259y.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 02 Jul 2022 12:11:21 +0200") Message-ID: <87mtdo7dyj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656970932; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=k/nR/qCRx0ZFNOGKrTNsgXQn+8HRD6XGsJvWOkxPKdY=; b=JcdW/+Wh55q/wf+tc2/NTx7d78fm501W9AFrezcElCQVdBq49Z9fjEZ11bXEqxjTcGxho8 424ZF4phD32s64DZFhMg33BDMoc726WSivxUU2spJhtZWRQ2elWKCEhi5UDX2EjYmu8LeZ DF5hutf6aWAQxO9MQnZdleE4nEu9JFOISzMsA2siBcA2n12yDltlyVi4l37BbH9Ik/qdXZ GQ5q1kAdcfKJkX54KukKi/zrJX6Fx+wpexhOIWmR5Pm3wmqYi9zmnsTvWG+rFRtNrZzvlx iajRRRG218XN9PLk3VK2w+1bC4EnlZ4HKe63PjlNEdKF+0lTsmIZSbujET/klQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656970932; a=rsa-sha256; cv=none; b=H6mwZ/bX/FbQ3FxppV65ioHGQrr4Q1lGssm3sl7FSmphrZ2uPMaCtB9nJdXOO+LhdEULDH Lg7NnTVGK8qR5tRC/nq2R3TkMw3D5NvHwaHZvRBXK574oHBWz3iIrYcGl+6Ne6GxRN7LkY wUL+2PR7Y/Y0MO5WH5y4J78qhoau9cpjqxfps+8ifAzZ+3/VxaPY3dUmOJ9PgyLQwk4LD3 OQ4f3zgZc9E8xYBJi9vPCuIE8o44IHER9ZJPAheqvZ9mEy5S87csYZc3ShxR92g0jHnLQw AlffeEWm5YSZqgGyLVwAI7287nnvKeoPjPDgphpfk1a37xe9YZz/OeYiiQqIFg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=cupwe1Q+; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.75 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=cupwe1Q+; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7493125754 X-Spam-Score: -4.75 X-Migadu-Scanner: scn0.migadu.com X-TUID: hNjUEYmScjJE Hi, Ludovic Court=C3=A8s skribis: >>> (define-public guile-next >>> (let ((version "3.0.7") (revision "0") >>> (commit "d70c1dbebf9ac0fd45af4578c23983ec4a7da535")) >> >> Conventionally 'revision' is put on another line -- for these kind of le= t bindings, >> (maybe all?), I would recommend to put all of them on separate lines. > > This one is a bug IMO: =E2=80=98let=E2=80=99 bindings should be treated s= pecially, and > currently they=E2=80=99re not. Commit 8d9291bd2c36810be50ea340cefa481a42c60a2b fixes this, and=E2=80=A6 >>> (substitute-keyword-arguments (package-arguments guile-3.0) >>> ((#:phases phases >>> '%standard-phases) `(modify-phases ,phases >> >> Put %standard-phases on the same line ad #:phases phases and `(modify-ph= ases ,phases >> on a new lineg=20 =E2=80=A6 the second part of this one. Ludo=E2=80=99.