From: Maxime Devos <maximedevos@telenet.be>
To: 56297@debbugs.gnu.org
Subject: bug#56297: Guix style imperfections
Date: Wed, 29 Jun 2022 11:33:05 +0200 [thread overview]
Message-ID: <9499300db3fe4222f7126240fb2acad3cdf4371b.camel@telenet.be> (raw)
[-- Attachment #1: Type: text/plain, Size: 2474 bytes --]
Hi,
"guix style" occasionally makes some decision that seem a bit
questionable to me. More concretely, copy the definition of guile-
next, put it in a .scm and rename it, and run
"guix style -L . guile-next-styleme". I get:
> (define-module (test))
> (use-modules (guix packages) (guix git-download) (gnu packages autotools) (gnu packages guile) (guix utils)
> (define-public guile-next
> (let ((version "3.0.7") (revision "0")
> (commit "d70c1dbebf9ac0fd45af4578c23983ec4a7da535"))
Conventionally 'revision' is put on another line -- for these kind of let bindings,
(maybe all?), I would recommend to put all of them on separate lines.
> (package
> (inherit guile-3.0)
> (name "guile-next-styleme")
> (version (git-version version revision commit))
> (source [snip, LGTM])
> (arguments
> (substitute-keyword-arguments (package-arguments guile-3.0)
> ((#:phases phases
> '%standard-phases) `(modify-phases ,phases
Put %standard-phases on the same line ad #:phases phases and `(modify-phases ,phases
on a new lineg
> (add-before 'check 'skip-failing-tests
> (lambda _
> (substitute* "test-suite/standalone/test-out-of-memory"
> (("!#") "!#
>
>(exit 77)
>"))
I'd prefer the original "!#\n\n(exit 77)\n" here, but I don't know if that's
something 'Guix style' could feasibly do (there might be situations where a
newline might be appropriate, how could "guix style" which is the case?).
> (delete-file
> "test-suite/tests/version.test") #t))))))
(Would be nice if "guix style" could be taught to remove those #t, but that seems
more a feature limitation than a bug to me.)
> (native-inputs (modify-inputs (package-native-inputs guile-3.0)
> (prepend autoconf
> automake
> libtool
> flex
> gnu-gettext
> texinfo
> gperf)))
I'd consider it tidier to put (modify-inputs ...) on a new line
> (synopsis "Development version of GNU Guile"))))
Question: do people agree with these style choices?
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next reply other threads:[~2022-06-29 9:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 9:33 Maxime Devos [this message]
2022-06-29 10:15 ` bug#56297: Guix style imperfections Liliana Marie Prikler
2022-06-29 10:18 ` Maxime Devos
2022-06-29 10:20 ` Liliana Marie Prikler
2022-06-29 10:19 ` Maxime Devos
2022-06-29 10:25 ` Liliana Marie Prikler
2022-07-02 10:11 ` Ludovic Courtès
2022-07-04 21:41 ` Ludovic Courtès
2022-07-19 13:40 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9499300db3fe4222f7126240fb2acad3cdf4371b.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=56297@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).