bug#18033: Add support for 'search-path-specifications' referring to files

unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed

* bug#18033: Add support for 'search-path-specifications' referring to files
       [not found]         ` <20140716100854.GB21262@jocasta.intra>
@ 2014-07-16 14:02           ` Ludovic Courtès
  2014-12-27 11:26             ` Ludovic Courtès
  0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2014-07-16 14:02 UTC (permalink / raw)
  To: 18033; +Cc: John Darrington

See use case below.

John Darrington <john@darrington.wattle.id.au> skribis:

> On Wed, Jul 16, 2014 at 11:23:12AM +0200, Ludovic Court??s wrote:
>      John Darrington <john@darrington.wattle.id.au> skribis:
>      
>      > On Tue, Jul 15, 2014 at 10:59:17PM +0200, Ludovic Court??s wrote:
>      
>      [...]
>      
>      >      The problem is that ???search-path-specification??? is meant for $PATH-like
>      >      variables that list directories, not files.
>      >
>      > That occurred to me too.  But what problems does it actually cause?
>      
>      That we can???t use it for $XML_CATALOG_FILES.
>      
>      >      So I see two solutions:
>      >      
>      >        1. Patch libxml2 so that it honors a new variable, say
>      >           $XML_CATALOG_DIRECTORIES, which would allow us to use
>      >           ???search-path-specification???.
>      >      
>      >        2. Augment support for search paths to allow file-based search paths.
>      >      
>      >      (2) may be best in the long run, but it has ramifications in different
>      >      places.
>      >      
>      >
>      > (1) seems like a good idea only if upstream can be persuaded to adopt it.
>      
>      Which is unlikely, given that it???s redundant with $XML_CATALOG_FILES.
>      
>      > What are the ramifications of (2) ?
>      
>      There are changes in the build tools, for instance ???search-path-as-list???
>      (used by ???set-path-environment-variable???, used in gnu-build-system.scm)
>      expects directories, not files.  And all this calls things
>      ???directories???.
>      
>      This is a change we could schedule for the next core-updates.
>
> This sounds like it is the most sensible solution. 
>
> J'

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#18033: Add support for 'search-path-specifications' referring to files
  2014-07-16 14:02           ` bug#18033: Add support for 'search-path-specifications' referring to files Ludovic Courtès
@ 2014-12-27 11:26             ` Ludovic Courtès
  2014-12-27 22:57               ` Ludovic Courtès
  0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2014-12-27 11:26 UTC (permalink / raw)
  To: 18033; +Cc: John Darrington

Commit 6aa47e3 implements the build-side part for that.

Ludo’.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#18033: Add support for 'search-path-specifications' referring to files
  2014-12-27 11:26             ` Ludovic Courtès
@ 2014-12-27 22:57               ` Ludovic Courtès
  2015-01-02 23:30                 ` Mark H Weaver
  0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2014-12-27 22:57 UTC (permalink / raw)
  To: 18033-done; +Cc: John Darrington

Commit af07095 extends ‘search-path-specification’ with a ‘file-type’
field, which can be 'regular.

Then, commit 7b21fe5 adds a ‘file-pattern’ field, to look for files
matching a pattern recursively.

Lastly, commit 2a8d440 uses these features for libxml2 and
$XML_CATALOG_FILES.

Comments welcome!

Ludo’.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#18033: Add support for 'search-path-specifications' referring to files
  2014-12-27 22:57               ` Ludovic Courtès
@ 2015-01-02 23:30                 ` Mark H Weaver
  2015-01-03 18:48                   ` Ludovic Courtès
  0 siblings, 1 reply; 5+ messages in thread
From: Mark H Weaver @ 2015-01-02 23:30 UTC (permalink / raw)
  To: 18033

Hi Ludovic,

ludo@gnu.org (Ludovic Courtès) writes:

> Commit af07095 extends ‘search-path-specification’ with a ‘file-type’
> field, which can be 'regular.
>
> Then, commit 7b21fe5 adds a ‘file-pattern’ field, to look for files
> matching a pattern recursively.
>
> Lastly, commit 2a8d440 uses these features for libxml2 and
> $XML_CATALOG_FILES.
>
> Comments welcome!

Something seems to have gone wrong here.  Trying to build 'emacs' on
current 'core-updates' (bf0baaf) on i686, I get this:

--8<---------------cut here---------------start------------->8---
mhw:~/guix-core-updates$ git describe
v0.8-499-gbf0baaf
mhw:~/guix-core-updates$ ./pre-inst-env guile
GNU Guile 2.0.11
Copyright (C) 1995-2014 Free Software Foundation, Inc.

Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
This program is free software, and you are welcome to redistribute it
under certain conditions; type `,show c' for details.

Enter `,help' for help.
scheme@(guile-user)> ,use (guix scripts build)
scheme@(guile-user)> (guix-build "emacs")
ERROR: In procedure concatenate:
ERROR: In procedure append: Wrong type argument in position 23 (expecting empty list): #<<search-path-specification> variable: "XML_CATALOG_FILES" files: ("xml") separator: " " file-type: regular file-pattern: "^catalog\\.xml$">

Entering a new prompt.  Type `,bt' for a backtrace or `,q' to continue.
scheme@(guile-user) [1]> ,bt
In ice-9/boot-9.scm:
   157:17 33 (catch srfi-34 #<procedure 92450a0 at guix/ui.scm:218:2 ()> #<procedure 927b2c0 at guix/ui.scm:218:2 (key c)> #)
   157:17 32 (catch system-error #<procedure 92450b0 at guix/scripts/build.scm:416:2 ()> #<procedure 927b300 at guix/ui.s…> …)
In guix/scripts/build.scm:
    420:6 31 (#<procedure 92450b0 at guix/scripts/build.scm:416:2 ()>)
    318:6 30 (options->derivations #<build-daemon 256.14 9211ae0> ((argument . "emacs") (system . "i686-linux") (# . #t) …))
In srfi/srfi-1.scm:
   664:12 29 (filter-map #<procedure 9e01a60 at guix/scripts/build.scm:318:18 (expr)> ((argument . #<package emacs-24.…>) …))
In guix/packages.scm:
   620:14 28 (cache #<package emacs-24.4 gnu/packages/emacs.scm:57 98f2060> ("i686-linux" . #t) #<procedure thunk ()>)
   869:10 27 (thunk)
    801:6 26 (bag->derivation #<build-daemon 256.14 9211ae0> #<<bag> name: "emacs-24.4" system: "i686-linux" target: #f b…> …)
In srfi/srfi-1.scm:
   578:27 25 (map #<procedure 9a5c498 at guix/packages.scm:803:30 (t-8656)> (("glib:bin" #<package glib-2.42.1 gnu/pa…>) …))
In guix/packages.scm:
   662:16 24 (expand-input #<build-daemon 256.14 9211ae0> #<package emacs-24.4 gnu/packages/emacs.scm:57 98f2060> ("gl…" …) …)
   620:14 23 (cache #<package glib-2.42.1 gnu/packages/glib.scm:120 99234e0> ("i686-linux" . #f) #<procedure thunk ()>)
   869:10 22 (thunk)
    801:6 21 (bag->derivation #<build-daemon 256.14 9211ae0> #<<bag> name: "glib-2.42.1" system: "i686-linux" target: #f …> …)
In srfi/srfi-1.scm:
   578:27 20 (map #<procedure 9a5c408 at guix/packages.scm:803:30 (t-8656)> (("source" #<origin "mirror://gnome/sourc…>) …))
In guix/packages.scm:
   662:16 19 (expand-input #<build-daemon 256.14 9211ae0> #<package glib-2.42.1 gnu/packages/glib.scm:120 99234e0> ("d…" …) …)
   620:14 18 (cache #<package dbus-1.8.12 gnu/packages/glib.scm:58 9923540> ("i686-linux" . #f) #<procedure thunk ()>)
   869:10 17 (thunk)
    801:6 16 (bag->derivation #<build-daemon 256.14 9211ae0> #<<bag> name: "dbus-1.8.12" system: "i686-linux" target: #f …> …)
In srfi/srfi-1.scm:
   578:27 15 (map #<procedure a00e390 at guix/packages.scm:803:30 (t-8656)> (("source" #<origin "http://dbus.freedesk…>) …))
In guix/packages.scm:
   662:16 14 (expand-input #<build-daemon 256.14 9211ae0> #<package dbus-1.8.12 gnu/packages/glib.scm:58 9923540> ("li…" …) …)
   620:14 13 (cache #<package libx11-1.6.2 gnu/packages/xorg.scm:4501 999ba20> ("i686-linux" . #f) #<procedure thunk ()>)
   869:10 12 (thunk)
    801:6 11 (bag->derivation #<build-daemon 256.14 9211ae0> #<<bag> name: "libx11-1.6.2" system: "i686-linux" target: #f…> …)
In srfi/srfi-1.scm:
   576:29 10 (map #<procedure a1ec390 at guix/packages.scm:803:30 (t-8656)> (("source" #<origin "mirror://xorg/indivi…>) …))
In guix/packages.scm:
   662:16  9 (expand-input #<build-daemon 256.14 9211ae0> #<package libx11-1.6.2 gnu/packages/xorg.scm:4501 999ba20> (# #) …)
   620:14  8 (cache #<package libxcb-1.11 gnu/packages/xorg.scm:4370 999bae0> ("i686-linux" . #f) #<procedure thunk ()>)
   869:10  7 (thunk)
    801:6  6 (bag->derivation #<build-daemon 256.14 9211ae0> #<<bag> name: "libxcb-1.11" system: "i686-linux" target: #f …> …)
In srfi/srfi-1.scm:
   578:27  5 (map #<procedure a388c00 at guix/packages.scm:803:30 (t-8656)> (("source" #<origin "mirror://xorg/indivi…>) …))
In guix/packages.scm:
   662:16  4 (expand-input #<build-daemon 256.14 9211ae0> #<package libxcb-1.11 gnu/packages/xorg.scm:4370 999bae0> ("…" …) …)
   620:14  3 (cache #<package libxslt-1.1.28 gnu/packages/xml.scm:106 9963c00> ("i686-linux" . #f) #<procedure thunk ()>)
   869:10  2 (thunk)
   806:26  1 (bag->derivation #<build-daemon 256.14 9211ae0> #<<bag> name: "libxslt-1.1.28" system: "i686-linux" target: …> …)
In unknown file:
           0 (concatenate (() () () () () () () () () () () () () () () () () (#<<search-path-specification> variabl…> …) …))
scheme@(guile-user) [1]>
--8<---------------cut here---------------end--------------->8---

      Mark

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#18033: Add support for 'search-path-specifications' referring to files
  2015-01-02 23:30                 ` Mark H Weaver
@ 2015-01-03 18:48                   ` Ludovic Courtès
  0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2015-01-03 18:48 UTC (permalink / raw)
  To: Mark H Weaver; +Cc: 18033

Mark H Weaver <mhw@netris.org> skribis:

> Something seems to have gone wrong here.  Trying to build 'emacs' on
> current 'core-updates' (bf0baaf) on i686, I get this:
>
> mhw:~/guix-core-updates$ git describe
> v0.8-499-gbf0baaf
> mhw:~/guix-core-updates$ ./pre-inst-env guile
> GNU Guile 2.0.11
> Copyright (C) 1995-2014 Free Software Foundation, Inc.
>
> Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
> This program is free software, and you are welcome to redistribute it
> under certain conditions; type `,show c' for details.
>
> Enter `,help' for help.
> scheme@(guile-user)> ,use (guix scripts build)
> scheme@(guile-user)> (guix-build "emacs")
> ERROR: In procedure concatenate:
> ERROR: In procedure append: Wrong type argument in position 23 (expecting empty list): #<<search-path-specification> variable: "XML_CATALOG_FILES" files: ("xml") separator: " " file-type: regular file-pattern: "^catalog\\.xml$">

A typo fixed in commit 7452806.  Thanks for the report!

Ludo’.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-01-03 18:49 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1405449096-29230-1-git-send-email-jmd@gnu.org>
     [not found] ` <1405449096-29230-5-git-send-email-jmd@gnu.org>
     [not found]   ` <87r41ml4nu.fsf@gnu.org>
     [not found]     ` <20140715214338.GB16482@jocasta.intra>
     [not found]       ` <87mwc9irnj.fsf@gnu.org>
     [not found]         ` <20140716100854.GB21262@jocasta.intra>
2014-07-16 14:02           ` bug#18033: Add support for 'search-path-specifications' referring to files Ludovic Courtès
2014-12-27 11:26             ` Ludovic Courtès
2014-12-27 22:57               ` Ludovic Courtès
2015-01-02 23:30                 ` Mark H Weaver
2015-01-03 18:48                   ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).