unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 27157@debbugs.gnu.org
Subject: bug#27157: [PATCH] Re: bug#27157: Building Guile 2.2 "times out"
Date: Thu, 31 Aug 2017 09:19:12 -0400	[thread overview]
Message-ID: <87lglzyiwf.fsf_-_@gmail.com> (raw)
In-Reply-To: <87lgpb75jk.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 01 Jun 2017 23:37:51 +0200")

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

Hi,

Here's a patch that fixes the problem originally reported (guile
was timing out while being built by 'guix environment guix', which was
capped to 3600 s of silent time.

I think the bug can now be closed.

Maxim


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-ui-Remove-max-silent-time-from-the-default-options.patch --]
[-- Type: text/x-patch, Size: 3817 bytes --]

From ba078ca1b8efa17fb0b2ee7b4269611c6bb4c3d6 Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Date: Wed, 30 Aug 2017 23:12:12 -0400
Subject: [PATCH] ui: Remove max-silent-time from the default options.

Having a finite default `max-silent-time' value for scripts such as 'guix
environment' could lead to timeouts when building subtitutes; this was
undesirable. This fixes bug #27157.

* guix/scripts/archive.scm (%default-options): Remove max-silent-time entry.
* guix/scripts/copy.scm (%default-options): Likewise.
* guix/scripts/environment.scm (%default-options): Likewise.
* guix/scripts/pack.scm (%default-options): Likewise.
* guix/scripts/package.scm (%default-options): Likewise.
* guix/scripts/pull.scm (%default-options): Likewise.
* guix/scripts/system.scm (%default-options): Likewise.
---
 guix/scripts/archive.scm     | 1 -
 guix/scripts/copy.scm        | 1 -
 guix/scripts/environment.scm | 1 -
 guix/scripts/pack.scm        | 1 -
 guix/scripts/package.scm     | 3 +--
 guix/scripts/pull.scm        | 1 -
 guix/scripts/system.scm      | 1 -
 7 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/guix/scripts/archive.scm b/guix/scripts/archive.scm
index 5ea19784d..a569848ae 100644
--- a/guix/scripts/archive.scm
+++ b/guix/scripts/archive.scm
@@ -54,7 +54,6 @@
   `((system . ,(%current-system))
     (substitutes? . #t)
     (graft? . #t)
-    (max-silent-time . 3600)
     (verbosity . 0)))
 
 (define (show-help)
diff --git a/guix/scripts/copy.scm b/guix/scripts/copy.scm
index 32438b99d..9ffffe8cc 100644
--- a/guix/scripts/copy.scm
+++ b/guix/scripts/copy.scm
@@ -151,7 +151,6 @@ Copy ITEMS to or from the specified host over SSH.\n"))
   `((system . ,(%current-system))
     (substitutes? . #t)
     (graft? . #t)
-    (max-silent-time . 3600)
     (verbosity . 0)))
 
 \f
diff --git a/guix/scripts/environment.scm b/guix/scripts/environment.scm
index 95ba199d9..0d6921833 100644
--- a/guix/scripts/environment.scm
+++ b/guix/scripts/environment.scm
@@ -179,7 +179,6 @@ COMMAND or an interactive shell in that environment.\n"))
   `((system . ,(%current-system))
     (substitutes? . #t)
     (graft? . #t)
-    (max-silent-time . 3600)
     (verbosity . 0)))
 
 (define (tag-package-arg opts arg)
diff --git a/guix/scripts/pack.scm b/guix/scripts/pack.scm
index c269a1fef..21fea446a 100644
--- a/guix/scripts/pack.scm
+++ b/guix/scripts/pack.scm
@@ -263,7 +263,6 @@ the image."
     (system . ,(%current-system))
     (substitutes? . #t)
     (graft? . #t)
-    (max-silent-time . 3600)
     (verbosity . 0)
     (symlinks . ())
     (compressor . ,(first %compressors))))
diff --git a/guix/scripts/package.scm b/guix/scripts/package.scm
index fa45bd48a..9ec6950c4 100644
--- a/guix/scripts/package.scm
+++ b/guix/scripts/package.scm
@@ -377,8 +377,7 @@ ENTRIES, a list of manifest entries, in the context of PROFILE."
 
 (define %default-options
   ;; Alist of default option values.
-  `((max-silent-time . 3600)
-    (verbosity . 0)
+  `((verbosity . 0)
     (graft? . #t)
     (substitutes? . #t)))
 
diff --git a/guix/scripts/pull.scm b/guix/scripts/pull.scm
index a1deec804..b1c87c870 100644
--- a/guix/scripts/pull.scm
+++ b/guix/scripts/pull.scm
@@ -96,7 +96,6 @@ Install it by running:
     (system . ,(%current-system))
     (substitutes? . #t)
     (graft? . #t)
-    (max-silent-time . 3600)
     (verbosity . 0)))
 
 (define (show-help)
diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm
index 8793c4092..773779318 100644
--- a/guix/scripts/system.scm
+++ b/guix/scripts/system.scm
@@ -864,7 +864,6 @@ Some ACTIONS support additional ARGS.\n"))
     (substitutes? . #t)
     (graft? . #t)
     (build-hook? . #t)
-    (max-silent-time . 3600)
     (verbosity . 0)
     (file-system-type . "ext4")
     (image-size . guess)
-- 
2.13.1


  parent reply	other threads:[~2017-08-31 13:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31  4:11 bug#27157: Building Guile 2.2 "times out" Maxim Cournoyer
2017-05-31 11:44 ` Ricardo Wurmus
2017-05-31 21:01   ` Ludovic Courtès
2017-06-01 16:06     ` Maxim Cournoyer
2017-06-01 21:37       ` Ludovic Courtès
2017-06-03 20:38         ` bug#27157: [PATCH] " Maxim Cournoyer
2017-06-03 21:37           ` Ludovic Courtès
2017-06-03 23:09             ` Maxim Cournoyer
2017-06-04 13:26               ` Ludovic Courtès
2017-08-31 13:19         ` Maxim Cournoyer [this message]
2017-09-01  9:10           ` Ludovic Courtès
2017-06-03  0:57   ` Mark H Weaver
2017-06-03  7:48     ` Ricardo Wurmus
2017-06-07 23:17       ` Mark H Weaver
2017-06-07 23:35         ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lglzyiwf.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=27157@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).