From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Cournoyer Subject: bug#27157: [PATCH] Re: bug#27157: Building Guile 2.2 "times out" Date: Thu, 31 Aug 2017 09:19:12 -0400 Message-ID: <87lglzyiwf.fsf_-_@gmail.com> References: <871sr5sm11.fsf@gmail.com> <878tld2quh.fsf@elephly.net> <87d1ao91vy.fsf@gnu.org> <87o9u7r8ug.fsf@gmail.com> <87lgpb75jk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnPOA-0003xA-8c for bug-guix@gnu.org; Thu, 31 Aug 2017 09:20:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnPO6-00023N-7u for bug-guix@gnu.org; Thu, 31 Aug 2017 09:20:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:56075) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dnPO6-00023I-4f for bug-guix@gnu.org; Thu, 31 Aug 2017 09:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dnPO5-0000hz-V0 for bug-guix@gnu.org; Thu, 31 Aug 2017 09:20:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87lgpb75jk.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 01 Jun 2017 23:37:51 +0200") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 27157@debbugs.gnu.org --=-=-= Content-Type: text/plain Hi, Here's a patch that fixes the problem originally reported (guile was timing out while being built by 'guix environment guix', which was capped to 3600 s of silent time. I think the bug can now be closed. Maxim --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-ui-Remove-max-silent-time-from-the-default-options.patch >From ba078ca1b8efa17fb0b2ee7b4269611c6bb4c3d6 Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Wed, 30 Aug 2017 23:12:12 -0400 Subject: [PATCH] ui: Remove max-silent-time from the default options. Having a finite default `max-silent-time' value for scripts such as 'guix environment' could lead to timeouts when building subtitutes; this was undesirable. This fixes bug #27157. * guix/scripts/archive.scm (%default-options): Remove max-silent-time entry. * guix/scripts/copy.scm (%default-options): Likewise. * guix/scripts/environment.scm (%default-options): Likewise. * guix/scripts/pack.scm (%default-options): Likewise. * guix/scripts/package.scm (%default-options): Likewise. * guix/scripts/pull.scm (%default-options): Likewise. * guix/scripts/system.scm (%default-options): Likewise. --- guix/scripts/archive.scm | 1 - guix/scripts/copy.scm | 1 - guix/scripts/environment.scm | 1 - guix/scripts/pack.scm | 1 - guix/scripts/package.scm | 3 +-- guix/scripts/pull.scm | 1 - guix/scripts/system.scm | 1 - 7 files changed, 1 insertion(+), 8 deletions(-) diff --git a/guix/scripts/archive.scm b/guix/scripts/archive.scm index 5ea19784d..a569848ae 100644 --- a/guix/scripts/archive.scm +++ b/guix/scripts/archive.scm @@ -54,7 +54,6 @@ `((system . ,(%current-system)) (substitutes? . #t) (graft? . #t) - (max-silent-time . 3600) (verbosity . 0))) (define (show-help) diff --git a/guix/scripts/copy.scm b/guix/scripts/copy.scm index 32438b99d..9ffffe8cc 100644 --- a/guix/scripts/copy.scm +++ b/guix/scripts/copy.scm @@ -151,7 +151,6 @@ Copy ITEMS to or from the specified host over SSH.\n")) `((system . ,(%current-system)) (substitutes? . #t) (graft? . #t) - (max-silent-time . 3600) (verbosity . 0))) diff --git a/guix/scripts/environment.scm b/guix/scripts/environment.scm index 95ba199d9..0d6921833 100644 --- a/guix/scripts/environment.scm +++ b/guix/scripts/environment.scm @@ -179,7 +179,6 @@ COMMAND or an interactive shell in that environment.\n")) `((system . ,(%current-system)) (substitutes? . #t) (graft? . #t) - (max-silent-time . 3600) (verbosity . 0))) (define (tag-package-arg opts arg) diff --git a/guix/scripts/pack.scm b/guix/scripts/pack.scm index c269a1fef..21fea446a 100644 --- a/guix/scripts/pack.scm +++ b/guix/scripts/pack.scm @@ -263,7 +263,6 @@ the image." (system . ,(%current-system)) (substitutes? . #t) (graft? . #t) - (max-silent-time . 3600) (verbosity . 0) (symlinks . ()) (compressor . ,(first %compressors)))) diff --git a/guix/scripts/package.scm b/guix/scripts/package.scm index fa45bd48a..9ec6950c4 100644 --- a/guix/scripts/package.scm +++ b/guix/scripts/package.scm @@ -377,8 +377,7 @@ ENTRIES, a list of manifest entries, in the context of PROFILE." (define %default-options ;; Alist of default option values. - `((max-silent-time . 3600) - (verbosity . 0) + `((verbosity . 0) (graft? . #t) (substitutes? . #t))) diff --git a/guix/scripts/pull.scm b/guix/scripts/pull.scm index a1deec804..b1c87c870 100644 --- a/guix/scripts/pull.scm +++ b/guix/scripts/pull.scm @@ -96,7 +96,6 @@ Install it by running: (system . ,(%current-system)) (substitutes? . #t) (graft? . #t) - (max-silent-time . 3600) (verbosity . 0))) (define (show-help) diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm index 8793c4092..773779318 100644 --- a/guix/scripts/system.scm +++ b/guix/scripts/system.scm @@ -864,7 +864,6 @@ Some ACTIONS support additional ARGS.\n")) (substitutes? . #t) (graft? . #t) (build-hook? . #t) - (max-silent-time . 3600) (verbosity . 0) (file-system-type . "ext4") (image-size . guess) -- 2.13.1 --=-=-=--