From: ludo@gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 27157@debbugs.gnu.org
Subject: bug#27157: [PATCH] Re: bug#27157: Building Guile 2.2 "times out"
Date: Sat, 03 Jun 2017 23:37:55 +0200 [thread overview]
Message-ID: <87mv9oiwgc.fsf@gnu.org> (raw)
In-Reply-To: <87tw3wq01b.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Sat, 03 Jun 2017 13:38:40 -0700")
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>>
>>> Guix build doesn't come with default option value for the
>>> max-silent-time, but guix environment does, and it is set to 3600
>>> s. This is defined under (guix scripts environment):
>>>
>>> (define %default-options
>>> `((system . ,(%current-system))
>>> (substitutes? . #t)
>>> (graft? . #t)
>>> (max-silent-time . 3600)
>>> (verbosity . 0)))
>>>
>>> If this is by design, I guess this issue can be closed.
>>
>> Good catch!
>>
>> However, according to ‘set-build-options’ in (guix store),
>> #:max-silent-time #f is equivalent to #:max-silent-time 3600.
>
> IIUC, this should only be true when (< (nix-server-minor-version
> server) #x61), as can be seen in (guix store):
>
> (when (< (nix-server-minor-version server) #x61)
> (let ((max-build-jobs (or max-build-jobs 1))
> (xomax-silent-time (or max-silent-time 3600)))
> (send (integer max-build-jobs) (integer max-silent-time))))
Oooh, indeed, sorry for the confusion. So what happens when
#:max-silent-time is #f is that we use the daemon’s default value, which
is infinite (zero) by default (see libstore/globals.cc).
> Given that the the nix worker protocole PROTOCOL_VERSION was bumped to
> 0x161 in commit deac976d3d26c7b85b9c90efb424b0aa94f1027c last January, I
> would *not* expect this condition to be evaluated.
>
> By the way, I find it weird that these conditions be expressed in terms
> of the minor version number only. The correctness of those is thus only
> guaranteed as long as the major number version is not bumped; this seems
> unwise.
Historical baggage: the major number was never bumped, I think. :-)
You’re right though.
>> At any rate, it would be good to remove ‘max-silent-time’ from all the
>> ‘%default-options’ variables, for consistency.
>>
>> Ludo’.
>
> I agree! In my view, interactive user commands should expect the users
> to take action themselves (e.g.; user notice no output for 3 hours; hits
> C-c. Or, user notice no output for 3 hours, check the process in top,
> sees it's still doing something, decides to leave it running a couple
> more hours).
Yes. Would you like to prepare a patch to remove ‘max-silent-time’ from
all the ‘%default-options’?
In the meantime I’ll add --timeout and --max-silent-time as options to
guix-daemon.
Thanks!
Ludo’.
next prev parent reply other threads:[~2017-06-03 21:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 4:11 bug#27157: Building Guile 2.2 "times out" Maxim Cournoyer
2017-05-31 11:44 ` Ricardo Wurmus
2017-05-31 21:01 ` Ludovic Courtès
2017-06-01 16:06 ` Maxim Cournoyer
2017-06-01 21:37 ` Ludovic Courtès
2017-06-03 20:38 ` bug#27157: [PATCH] " Maxim Cournoyer
2017-06-03 21:37 ` Ludovic Courtès [this message]
2017-06-03 23:09 ` Maxim Cournoyer
2017-06-04 13:26 ` Ludovic Courtès
2017-08-31 13:19 ` Maxim Cournoyer
2017-09-01 9:10 ` Ludovic Courtès
2017-06-03 0:57 ` Mark H Weaver
2017-06-03 7:48 ` Ricardo Wurmus
2017-06-07 23:17 ` Mark H Weaver
2017-06-07 23:35 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mv9oiwgc.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=27157@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).