From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Lemmer Webber Subject: bug#30680: [PATCH] Patch Racket to fix bug #30680 Date: Sun, 12 Aug 2018 16:35:27 -0400 Message-ID: <87lg9bfhm8.fsf@dustycloud.org> References: <87r2j3bfy0.fsf@ngyro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fox5n-0003Fi-GE for bug-guix@gnu.org; Sun, 12 Aug 2018 16:36:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fox5m-0003eZ-IQ for bug-guix@gnu.org; Sun, 12 Aug 2018 16:36:03 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:44028) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fox5m-0003eP-Dy for bug-guix@gnu.org; Sun, 12 Aug 2018 16:36:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fox5m-00041z-6W for bug-guix@gnu.org; Sun, 12 Aug 2018 16:36:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-reply-to: <87r2j3bfy0.fsf@ngyro.com> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Timothy Sample Cc: guix-patches@gnu.org Timothy Sample writes: > Hi Guix, > > (Patch is attached below.) > > This patch fixes . It does so by > patching Racket to treat store files specially. I have verified that it > both fixes the bug above and still recompiles non-store files. > > As far as I can tell, Racket only uses these checksums as part of its > =E2=80=9Csetup=E2=80=9D library. When deciding whether to use a bytecode= file during > evaluation, it does not verify the checksum. That=E2=80=99s why only the > =E2=80=9Csetup=E2=80=9D code is patched. > > As a side note, both GDB and Go have similar problems: > > =E2=80=A2 > =E2=80=A2 > > If there ever is a more general solution, this patch will no longer be > necessary. > > (Also, Racket takes a bit of time to build, so reviewers beware!) > > > -- Tim Oh wait... it seems like the patch is not actually attached? I assume that must be an error! Actually if I look at the raw view of the email I see: --=3D-=3D-=3D Content-Type: message/external-body; name=3D"/home/samplet/code/guix-wip-racket/0001-gnu-racket-Ignore-bytecode= -checksums-in-the-store.patch"; access-type=3Dlocal-file Content-Type: text/x-patch Content-ID: <87pnynbfy0.fsf@ngyro.com> Content-Transfer-Encoding: binary --=3D-=3D-=3D So it looks like it should be attached, but I don't see the file contents? Perhaps this is an error on my end! But I'm very eager to test this patch!