* bug#42702: catch2 build failure on ARM
@ 2020-08-03 18:22 maxim.cournoyer
2020-08-03 18:25 ` maxim.cournoyer
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: maxim.cournoyer @ 2020-08-03 18:22 UTC (permalink / raw)
To: 42702
On ARM systems, (armhf-linux, aarch64-linux), the catch2 package fails to build, due to a
compilation warning treated as an error:
[ 90%] Building CXX object CMakeFiles/SelfTest.dir/include/reporters/catch_reporter_xml.cpp.o
/gnu/store/ap7hgyv4rjqmhg4a6cb6cypsh3g1f5q4-gcc-7.5.0/bin/c++ -I/tmp/guix-build-catch2-2.1.2.drv-0/source/include -O2 -g -DNDEBUG -Wall -Wextra -Wunreachable-code -Wpedantic -Werror -std=c++11 -o CMakeFiles/SelfTest.dir/include/reporters/catch_reporter_xml.cpp.o -c /tmp/guix-build-catch2-2.1.2.drv-0/source/include/reporters/catch_reporter_xml.cpp
/tmp/guix-build-catch2-2.1.2.drv-0/source/include/internal/catch_tostring.cpp: In static member function ‘static std::__cxx11::string Catch::StringMaker<char>::convert(char)’:
/tmp/guix-build-catch2-2.1.2.drv-0/source/include/internal/catch_tostring.cpp:202:21: error: comparison is always true due to limited range of data type [-Werror=type-limits]
} else if ('\0' <= value && value < ' ') {
~~~~~^~~~~~~~
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#42702: catch2 build failure on ARM
2020-08-03 18:22 bug#42702: catch2 build failure on ARM maxim.cournoyer
@ 2020-08-03 18:25 ` maxim.cournoyer
2020-08-03 23:09 ` Danny Milosavljevic
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: maxim.cournoyer @ 2020-08-03 18:25 UTC (permalink / raw)
To: maxim.cournoyer; +Cc: 42702
maxim.cournoyer@gmail.com writes:
> On ARM systems, (armhf-linux, aarch64-linux), the catch2 package fails to build, due to a
> compilation warning treated as an error:
>
> [ 90%] Building CXX object CMakeFiles/SelfTest.dir/include/reporters/catch_reporter_xml.cpp.o
> /gnu/store/ap7hgyv4rjqmhg4a6cb6cypsh3g1f5q4-gcc-7.5.0/bin/c++ -I/tmp/guix-build-catch2-2.1.2.drv-0/source/include -O2 -g -DNDEBUG -Wall -Wextra -Wunreachable-code -Wpedantic -Werror -std=c++11 -o CMakeFiles/SelfTest.dir/include/reporters/catch_reporter_xml.cpp.o -c /tmp/guix-build-catch2-2.1.2.drv-0/source/include/reporters/catch_reporter_xml.cpp
> /tmp/guix-build-catch2-2.1.2.drv-0/source/include/internal/catch_tostring.cpp: In static member function ‘static std::__cxx11::string Catch::StringMaker<char>::convert(char)’:
> /tmp/guix-build-catch2-2.1.2.drv-0/source/include/internal/catch_tostring.cpp:202:21: error: comparison is always true due to limited range of data type [-Werror=type-limits]
> } else if ('\0' <= value && value < ' ') {
> ~~~~~^~~~~~~~
This is also the case for i686-linux.
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#42702: catch2 build failure on ARM
2020-08-03 18:22 bug#42702: catch2 build failure on ARM maxim.cournoyer
2020-08-03 18:25 ` maxim.cournoyer
@ 2020-08-03 23:09 ` Danny Milosavljevic
2020-08-04 7:44 ` Efraim Flashner
[not found] ` <handler.42702.D42702.159652711520285.notifdone@debbugs.gnu.org>
3 siblings, 0 replies; 6+ messages in thread
From: Danny Milosavljevic @ 2020-08-03 23:09 UTC (permalink / raw)
To: maxim.cournoyer; +Cc: 42702
[-- Attachment #1: Type: text/plain, Size: 452 bytes --]
Hi Maxim,
On Mon, 03 Aug 2020 14:22:21 -0400
maxim.cournoyer@gmail.com wrote:
> } else if ('\0' <= value && value < ' ') {
> ~~~~~^~~~~~~~
I think that this tries to find non-printable characters, so those with ASCII
codes 0 < value < 32 and 128 < value < 255. But char is unsigned on ARM, so
it won't do that with the code above. Therefore, this IS an error and treating
it as a warning would be very, very, bad.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#42702: catch2 build failure on ARM
2020-08-03 18:22 bug#42702: catch2 build failure on ARM maxim.cournoyer
2020-08-03 18:25 ` maxim.cournoyer
2020-08-03 23:09 ` Danny Milosavljevic
@ 2020-08-04 7:44 ` Efraim Flashner
[not found] ` <handler.42702.D42702.159652711520285.notifdone@debbugs.gnu.org>
3 siblings, 0 replies; 6+ messages in thread
From: Efraim Flashner @ 2020-08-04 7:44 UTC (permalink / raw)
To: maxim.cournoyer; +Cc: 42702-done
[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]
On Mon, Aug 03, 2020 at 02:22:21PM -0400, maxim.cournoyer@gmail.com wrote:
> On ARM systems, (armhf-linux, aarch64-linux), the catch2 package fails to build, due to a
> compilation warning treated as an error:
>
> [ 90%] Building CXX object CMakeFiles/SelfTest.dir/include/reporters/catch_reporter_xml.cpp.o
> /gnu/store/ap7hgyv4rjqmhg4a6cb6cypsh3g1f5q4-gcc-7.5.0/bin/c++ -I/tmp/guix-build-catch2-2.1.2.drv-0/source/include -O2 -g -DNDEBUG -Wall -Wextra -Wunreachable-code -Wpedantic -Werror -std=c++11 -o CMakeFiles/SelfTest.dir/include/reporters/catch_reporter_xml.cpp.o -c /tmp/guix-build-catch2-2.1.2.drv-0/source/include/reporters/catch_reporter_xml.cpp
> /tmp/guix-build-catch2-2.1.2.drv-0/source/include/internal/catch_tostring.cpp: In static member function ‘static std::__cxx11::string Catch::StringMaker<char>::convert(char)’:
> /tmp/guix-build-catch2-2.1.2.drv-0/source/include/internal/catch_tostring.cpp:202:21: error: comparison is always true due to limited range of data type [-Werror=type-limits]
> } else if ('\0' <= value && value < ' ') {
> ~~~~~^~~~~~~~
Fixed in 7f101e7ceb869882b9a959cb7801aea64c26704d
Do note that this breaks libfive, which has no dependants.
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread[parent not found: <handler.42702.D42702.159652711520285.notifdone@debbugs.gnu.org>]
* bug#42702: closed (Re: bug#42702: catch2 build failure on ARM)
[not found] ` <handler.42702.D42702.159652711520285.notifdone@debbugs.gnu.org>
@ 2020-08-24 3:27 ` Maxim Cournoyer
2020-08-24 8:45 ` Efraim Flashner
0 siblings, 1 reply; 6+ messages in thread
From: Maxim Cournoyer @ 2020-08-24 3:27 UTC (permalink / raw)
To: 42702
Hello,
[...]
> From: Efraim Flashner <efraim@flashner.co.il>
> Subject: Re: bug#42702: catch2 build failure on ARM
> To: maxim.cournoyer@gmail.com
> Cc: 42702-done@debbugs.gnu.org
> Date: Tue, 4 Aug 2020 10:44:32 +0300 (2 weeks, 5 days, 19 hours ago)
>
> On Mon, Aug 03, 2020 at 02:22:21PM -0400, maxim.cournoyer@gmail.com wrote:
>> On ARM systems, (armhf-linux, aarch64-linux), the catch2 package fails to build, due to a
>> compilation warning treated as an error:
>>
>> [ 90%] Building CXX object CMakeFiles/SelfTest.dir/include/reporters/catch_reporter_xml.cpp.o
>> /gnu/store/ap7hgyv4rjqmhg4a6cb6cypsh3g1f5q4-gcc-7.5.0/bin/c++ -I/tmp/guix-build-catch2-2.1.2.drv-0/source/include -O2 -g -DNDEBUG -Wall -Wextra -Wunreachable-code -Wpedantic -Werror -std=c++11 -o CMakeFiles/SelfTest.dir/include/reporters/catch_reporter_xml.cpp.o -c /tmp/guix-build-catch2-2.1.2.drv-0/source/include/reporters/catch_reporter_xml.cpp
>> /tmp/guix-build-catch2-2.1.2.drv-0/source/include/internal/catch_tostring.cpp: In static member function ‘static std::__cxx11::string Catch::StringMaker<char>::convert(char)’:
>> /tmp/guix-build-catch2-2.1.2.drv-0/source/include/internal/catch_tostring.cpp:202:21: error: comparison is always true due to limited range of data type [-Werror=type-limits]
>> } else if ('\0' <= value && value < ' ') {
>> ~~~~~^~~~~~~~
>
> Fixed in 7f101e7ceb869882b9a959cb7801aea64c26704d
>
> Do note that this breaks libfive, which has no dependants.
Thank you for fixing it! :-)
Maxim
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-24 8:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-03 18:22 bug#42702: catch2 build failure on ARM maxim.cournoyer
2020-08-03 18:25 ` maxim.cournoyer
2020-08-03 23:09 ` Danny Milosavljevic
2020-08-04 7:44 ` Efraim Flashner
[not found] ` <handler.42702.D42702.159652711520285.notifdone@debbugs.gnu.org>
2020-08-24 3:27 ` bug#42702: closed (Re: bug#42702: catch2 build failure on ARM) Maxim Cournoyer
2020-08-24 8:45 ` Efraim Flashner
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).