unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: maxim.cournoyer@gmail.com
Cc: 42702@debbugs.gnu.org
Subject: bug#42702: catch2 build failure on ARM
Date: Tue, 4 Aug 2020 01:09:28 +0200	[thread overview]
Message-ID: <20200804010928.455f2637@scratchpost.org> (raw)
In-Reply-To: <87pn87oahu.fsf@hurd.i-did-not-set--mail-host-address--so-tickle-me>

[-- Attachment #1: Type: text/plain, Size: 452 bytes --]

Hi Maxim,

On Mon, 03 Aug 2020 14:22:21 -0400
maxim.cournoyer@gmail.com wrote:

>      } else if ('\0' <= value && value < ' ') {
>                 ~~~~~^~~~~~~~

I think that this tries to find non-printable characters, so those with ASCII
codes 0 < value < 32 and 128 < value < 255.  But char is unsigned on ARM, so
it won't do that with the code above.  Therefore, this IS an error and treating
it as a warning would be very, very, bad.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2020-08-03 23:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03 18:22 bug#42702: catch2 build failure on ARM maxim.cournoyer
2020-08-03 18:25 ` maxim.cournoyer
2020-08-03 23:09 ` Danny Milosavljevic [this message]
2020-08-04  7:44 ` Efraim Flashner
     [not found] ` <handler.42702.D42702.159652711520285.notifdone@debbugs.gnu.org>
2020-08-24  3:27   ` bug#42702: closed (Re: bug#42702: catch2 build failure on ARM) Maxim Cournoyer
2020-08-24  8:45     ` Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200804010928.455f2637@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=42702@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).