From: "Ludovic Courtès" <ludo@gnu.org>
To: Thomas Schmitt <scdbackup@gmx.net>
Cc: bug-xorriso@gnu.org, 33639@debbugs.gnu.org
Subject: bug#33639: ISO installer image is broken on i686
Date: Mon, 08 Apr 2019 10:50:29 +0200 [thread overview]
Message-ID: <87h8b8284q.fsf@gnu.org> (raw)
In-Reply-To: <2660367208964033194@scdbackup.webframe.org> (Thomas Schmitt's message of "Sun, 07 Apr 2019 23:35:16 +0200")
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
Hello,
"Thomas Schmitt" <scdbackup@gmx.net> skribis:
> The fact that the VM always sees the expected size but the host sees varying
> sizes supports the suspicion that at the end of the VM its i/o buffers or
> virtual disk are not always properly flushed to the i/o system of the host.
> The varying success smells like a race condition.
Indeed, that rings a bell: I fixed a similar issue in commit
0dc7d298a33f83d5f02a962b5f1bd24ee0e8ef07.
Florian: could you check whether the patch below solves the problem for
you?
Thanks,
Ludo’.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1340 bytes --]
diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm
index db9b1707d7..3ee03c84a0 100644
--- a/gnu/system/vm.scm
+++ b/gnu/system/vm.scm
@@ -240,7 +240,11 @@ made available under the /xchg CIFS share."
#:target-arm32? #$(target-arm32?)
#:disk-image-format #$disk-image-format
#:disk-image-size size
- #:references-graphs graphs))))))
+ #:references-graphs graphs)
+
+ ;; Make sure I/O buffers get flushed. This is particularly
+ ;; important when MAKE-DISK-IMAGE? is true.
+ (sync))))))
(gexp->derivation name builder
;; TODO: Require the "kvm" feature.
@@ -530,10 +534,7 @@ should set REGISTER-CLOSURES? to #f."
#$os
#:compressor '(#+(file-append gzip "/bin/gzip") "-9n")
#:creation-time (make-time time-utc 0 1)
- #:transformations `((,root-directory -> "")))
-
- ;; Make sure the tarball is fully written before rebooting.
- (sync))))))
+ #:transformations `((,root-directory -> ""))))))))
(expression->derivation-in-linux-vm
name build
#:make-disk-image? #f
next prev parent reply other threads:[~2019-04-08 8:51 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 0:02 bug#33639: ISO installer image is broken on i686 Ludovic Courtès
2018-12-06 7:19 ` Ludovic Courtès
2018-12-06 10:34 ` Ludovic Courtès
2018-12-06 14:08 ` Thomas Schmitt
2018-12-06 15:34 ` Ludovic Courtès
2018-12-06 16:59 ` Thomas Schmitt
2018-12-15 18:40 ` Thomas Schmitt
2018-12-15 19:24 ` Thomas Schmitt
2018-12-16 15:52 ` Ludovic Courtès
2018-12-16 16:52 ` Thomas Schmitt
2018-12-18 11:16 ` Ludovic Courtès
2018-12-18 21:45 ` Thomas Schmitt
2018-12-19 14:05 ` Ludovic Courtès
2018-12-19 14:51 ` Thomas Schmitt
2018-12-20 13:38 ` Thomas Schmitt
2018-12-21 20:44 ` Ludovic Courtès
2018-12-21 21:42 ` Thomas Schmitt
2019-04-07 20:18 ` pelzflorian (Florian Pelz)
2019-04-07 21:35 ` Thomas Schmitt
2019-04-08 8:50 ` Ludovic Courtès [this message]
2019-04-09 22:13 ` pelzflorian (Florian Pelz)
2019-04-10 11:17 ` Thomas Schmitt
2019-04-10 21:23 ` pelzflorian (Florian Pelz)
2019-04-12 21:26 ` Ludovic Courtès
2019-04-13 6:37 ` Thomas Schmitt
2019-04-13 13:46 ` pelzflorian (Florian Pelz)
2019-04-13 16:20 ` Thomas Schmitt
2019-04-14 21:43 ` Ludovic Courtès
2019-04-15 6:07 ` pelzflorian (Florian Pelz)
2019-04-15 8:16 ` Thomas Schmitt
2019-04-15 8:35 ` Thomas Schmitt
2019-04-19 11:40 ` bug#35283: ISO images are not reproducible Ludovic Courtès
2019-04-19 12:46 ` Thomas Schmitt
2019-04-20 22:57 ` Ludovic Courtès
2019-04-21 8:17 ` Thomas Schmitt
2019-04-21 16:42 ` Ludovic Courtès
2019-04-21 18:44 ` Thomas Schmitt
2019-04-20 23:03 ` bug#35283: [PATCH] mformat: initialize boot sector before writing it Ludovic Courtès
2019-04-21 16:32 ` bug#35283: [PATCH] grub-mkrescue: Allow users to specify a FAT serial number Ludovic Courtès
2019-04-14 15:47 ` bug#33639: ISO installer image is broken on i686 Ludovic Courtès
2019-04-15 16:54 ` pelzflorian (Florian Pelz)
2019-04-15 17:55 ` Thomas Schmitt
2019-04-16 9:57 ` Gábor Boskovits
2019-04-16 21:01 ` Ludovic Courtès
2019-04-17 9:03 ` pelzflorian (Florian Pelz)
2018-12-06 16:28 ` Ludovic Courtès
2018-12-06 17:29 ` Thomas Schmitt
2018-12-07 22:51 ` Ludovic Courtès
2018-12-08 12:42 ` Thomas Schmitt
2018-12-06 9:35 ` swedebugia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8b8284q.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=33639@debbugs.gnu.org \
--cc=bug-xorriso@gnu.org \
--cc=scdbackup@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).