* bug#30641: Make 'guix refresh' to ignore "v" prefix in CPAN updater
[not found] ` <87tvu68c74.fsf@fastmail.com>
@ 2018-02-28 2:12 ` Oleg Pykhalov
2018-03-01 13:58 ` Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: Oleg Pykhalov @ 2018-02-28 2:12 UTC (permalink / raw)
To: 30641
[-- Attachment #1: Type: text/plain, Size: 1817 bytes --]
Hello Guix,
Previous discussion [1] talks about ‘guix refresh’ for CPAN updater
needs to ignore ‘v’ prefix in a ‘version’ field of a package record.
Marius Bakke <mbakke@fastmail.com> writes:
> Oleg Pykhalov <go.wigust@gmail.com> writes:
>
>> Marius Bakke <mbakke@fastmail.com> writes:
>>
>>> Sorry, I meant the opposite: we don't add the "v" prefix. It would be
>>> nice to make the CPAN updater aware of that.
>>
>> I'll close current bug report. Should we open a new one for CPAN
>> updater fix purpose?
Sounds good! I think the GitHub updater already ignores the "v" prefix
when comparing versions, so there might be some inspiration there.
>>>> I see a bunch of packages packages have "v" prefix:
>>>> --8<---------------cut here---------------start------------->8---
>>>> ./gnu/packages/perl.scm:3599: (version "v2.49.1")
>>>> ./gnu/packages/perl.scm:7969: (version "v0.0.2")
>>>> ./gnu/packages/perl.scm:8697: (version "v0.2.13")
>>>> ./gnu/packages/networking.scm:778: (version "v0.003")
>>>> ./gnu/packages/mail.scm:1755: (version "v2.9.0")
>>>> --8<---------------cut here---------------end--------------->8---
>>>
>>> Let's fix these :-)
>>
>> I guess it's better to do after a CPAN updater fix. WDYT?
No opinion either way :-)
Example of ‘guix refresh’ [2] wants to upgrade a package with the same
version because of ‘v’ prefix:
--8<---------------cut here---------------start------------->8---
/home/natsu/src/guix-wip-licensecheck/gnu/packages/license.scm:108:2: licensecheck <at> 3.0.31: can be upgraded to v3.0.31
--8<---------------cut here---------------end--------------->8---
[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30274#164
[2] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30274#161
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#30641: Make 'guix refresh' to ignore "v" prefix in CPAN updater
2018-02-28 2:12 ` bug#30641: Make 'guix refresh' to ignore "v" prefix in CPAN updater Oleg Pykhalov
@ 2018-03-01 13:58 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2018-03-01 13:58 UTC (permalink / raw)
To: Oleg Pykhalov; +Cc: 30641-done
Hi,
Oleg Pykhalov <go.wigust@gmail.com> skribis:
> Marius Bakke <mbakke@fastmail.com> writes:
>
>> Oleg Pykhalov <go.wigust@gmail.com> writes:
>>
>>> Marius Bakke <mbakke@fastmail.com> writes:
>>>
>>>> Sorry, I meant the opposite: we don't add the "v" prefix. It would be
>>>> nice to make the CPAN updater aware of that.
>>>
>>> I'll close current bug report. Should we open a new one for CPAN
>>> updater fix purpose?
>
> Sounds good! I think the GitHub updater already ignores the "v" prefix
> when comparing versions, so there might be some inspiration there.
>
>>>>> I see a bunch of packages packages have "v" prefix:
>>>>> --8<---------------cut here---------------start------------->8---
>>>>> ./gnu/packages/perl.scm:3599: (version "v2.49.1")
>>>>> ./gnu/packages/perl.scm:7969: (version "v0.0.2")
>>>>> ./gnu/packages/perl.scm:8697: (version "v0.2.13")
>>>>> ./gnu/packages/networking.scm:778: (version "v0.003")
>>>>> ./gnu/packages/mail.scm:1755: (version "v2.9.0")
>>>>> --8<---------------cut here---------------end--------------->8---
>>>>
>>>> Let's fix these :-)
>>>
>>> I guess it's better to do after a CPAN updater fix. WDYT?
>
> No opinion either way :-)
Could you fix these?
> Example of ‘guix refresh’ [2] wants to upgrade a package with the same
> version because of ‘v’ prefix:
>
> /home/natsu/src/guix-wip-licensecheck/gnu/packages/license.scm:108:2: licensecheck <at> 3.0.31: can be upgraded to v3.0.31
That turned out to be easy to fix, done in
b402f4ee34d35f9b934b5449d2cc419dc287895e.
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-01 13:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20180128184437.32296-1-go.wigust@gmail.com>
[not found] ` <87a7wxrdop.fsf@gmail.com>
[not found] ` <87vaep9kg0.fsf@fastmail.com>
[not found] ` <87o9kgkchr.fsf@gmail.com>
[not found] ` <87h8q89e15.fsf@fastmail.com>
[not found] ` <87vaemgv37.fsf@gmail.com>
[not found] ` <87tvu68c74.fsf@fastmail.com>
2018-02-28 2:12 ` bug#30641: Make 'guix refresh' to ignore "v" prefix in CPAN updater Oleg Pykhalov
2018-03-01 13:58 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).