unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 30641-done@debbugs.gnu.org
Subject: bug#30641: Make 'guix refresh' to ignore "v" prefix in CPAN updater
Date: Thu, 01 Mar 2018 14:58:04 +0100	[thread overview]
Message-ID: <87fu5j6gpf.fsf@gnu.org> (raw)
In-Reply-To: <87r2p5g8vp.fsf_-_@gmail.com> (Oleg Pykhalov's message of "Wed, 28 Feb 2018 05:12:26 +0300")

Hi,

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> Marius Bakke <mbakke@fastmail.com> writes:
>
>> Oleg Pykhalov <go.wigust@gmail.com> writes:
>>
>>> Marius Bakke <mbakke@fastmail.com> writes:
>>>
>>>> Sorry, I meant the opposite: we don't add the "v" prefix.  It would be
>>>> nice to make the CPAN updater aware of that.
>>>
>>> I'll close current bug report.  Should we open a new one for CPAN
>>> updater fix purpose?
>
> Sounds good!  I think the GitHub updater already ignores the "v" prefix
> when comparing versions, so there might be some inspiration there.
>
>>>>> I see a bunch of packages packages have "v" prefix:
>>>>> --8<---------------cut here---------------start------------->8---
>>>>> ./gnu/packages/perl.scm:3599:    (version "v2.49.1")
>>>>> ./gnu/packages/perl.scm:7969:    (version "v0.0.2")
>>>>> ./gnu/packages/perl.scm:8697:  (version "v0.2.13")
>>>>> ./gnu/packages/networking.scm:778:  (version "v0.003")
>>>>> ./gnu/packages/mail.scm:1755:  (version "v2.9.0")
>>>>> --8<---------------cut here---------------end--------------->8---
>>>>
>>>> Let's fix these :-)
>>>
>>> I guess it's better to do after a CPAN updater fix.  WDYT?
>
> No opinion either way :-)

Could you fix these?

> Example of ‘guix refresh’ [2] wants to upgrade a package with the same
> version because of ‘v’ prefix:
>
> /home/natsu/src/guix-wip-licensecheck/gnu/packages/license.scm:108:2: licensecheck <at> 3.0.31: can be upgraded to v3.0.31

That turned out to be easy to fix, done in
b402f4ee34d35f9b934b5449d2cc419dc287895e.

Thanks,
Ludo’.

      reply	other threads:[~2018-03-01 13:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180128184437.32296-1-go.wigust@gmail.com>
     [not found] ` <87a7wxrdop.fsf@gmail.com>
     [not found]   ` <87vaep9kg0.fsf@fastmail.com>
     [not found]     ` <87o9kgkchr.fsf@gmail.com>
     [not found]       ` <87h8q89e15.fsf@fastmail.com>
     [not found]         ` <87vaemgv37.fsf@gmail.com>
     [not found]           ` <87tvu68c74.fsf@fastmail.com>
2018-02-28  2:12             ` bug#30641: Make 'guix refresh' to ignore "v" prefix in CPAN updater Oleg Pykhalov
2018-03-01 13:58               ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fu5j6gpf.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=30641-done@debbugs.gnu.org \
    --cc=go.wigust@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).