From: ludo@gnu.org (Ludovic Courtès)
To: Carlo Zancanaro <carlo@zancanaro.id.au>
Cc: 23170@debbugs.gnu.org
Subject: bug#23170: [PATCH shepherd] Restart dependent services on service restart
Date: Sun, 26 Aug 2018 23:08:34 +0200 [thread overview]
Message-ID: <87ftz07s4t.fsf@gnu.org> (raw)
In-Reply-To: <871samqcz4.fsf@zancanaro.id.au> (Carlo Zancanaro's message of "Sun, 26 Aug 2018 08:48:47 +1000")
Carlo Zancanaro <carlo@zancanaro.id.au> skribis:
> On Sun, Aug 26 2018, Ludovic Courtès wrote:
>> I wonder if there are cases where one might want to restart a
>> service without restarting its dependent services. We can probably
>> ignore it for now, but perhaps we’ll need to add a flag or a
>> separate action later.
>>
>> Thoughts?
>
> I think this is best served by 'herd stop', followed by 'herd
> start'. This patch just special-cases the 'restart' action, so
> manually stopping then starting a service will behave as the old
> restart used to.
Great, I had overlooked this.
>> For clarity, should we do an explicit “herd stop test1” followed by
>> “herd start test1”? I know it’s currently equivalent under the
>> hood, but it might be slightly clearer. WDYT?
>
> Hopefully the above also answers this, too.
It does, thanks!
> I did consider whether it was worth adding a test for 'herd stop' to
> make sure it still stops dependent services, and 'herd start' to make
> sure it doesn't start dependent services, but in the end I decided not
> to. I'm happy to send through another patch to test these cases,
> though, if you think it would be worthwhile.
No, that’s fine.
I forgot if this was already done, but perhaps you can add a bit in the
manual to insist that ‘restart’ is not quite the same as ‘stop’ +
‘start’.
Anyway, it all LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2018-08-26 21:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 13:23 bug#23170: Shepherd doesn't restart previously running dependent services Thompson, David
2018-08-25 11:33 ` bug#23170: [PATCH shepherd] Restart dependent services on service restart Carlo Zancanaro
2018-08-25 14:41 ` Ludovic Courtès
2018-08-25 22:48 ` Carlo Zancanaro
2018-08-26 21:08 ` Ludovic Courtès [this message]
2018-08-26 22:05 ` Carlo Zancanaro
2018-08-27 11:05 ` Ludovic Courtès
2018-08-27 12:42 ` Carlo Zancanaro
2018-08-26 22:05 ` Carlo Zancanaro
2018-08-27 17:53 ` Clément Lassieur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftz07s4t.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=23170@debbugs.gnu.org \
--cc=carlo@zancanaro.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).