From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#23170: [PATCH shepherd] Restart dependent services on service restart Date: Sun, 26 Aug 2018 23:08:34 +0200 Message-ID: <87ftz07s4t.fsf@gnu.org> References: <874lfi65rv.fsf@zancanaro.id.au> <87bm9qbjb4.fsf@gnu.org> <871samqcz4.fsf@zancanaro.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fu2HP-0004nk-Bs for bug-guix@gnu.org; Sun, 26 Aug 2018 17:09:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fu2HO-0000PT-9Y for bug-guix@gnu.org; Sun, 26 Aug 2018 17:09:03 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:56676) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fu2HO-0000P7-3j for bug-guix@gnu.org; Sun, 26 Aug 2018 17:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fu2HN-0001uh-R6 for bug-guix@gnu.org; Sun, 26 Aug 2018 17:09:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <871samqcz4.fsf@zancanaro.id.au> (Carlo Zancanaro's message of "Sun, 26 Aug 2018 08:48:47 +1000") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Carlo Zancanaro Cc: 23170@debbugs.gnu.org Carlo Zancanaro skribis: > On Sun, Aug 26 2018, Ludovic Court=C3=A8s wrote: >> I wonder if there are cases where one might want to restart a >> service without restarting its dependent services. We can probably >> ignore it for now, but perhaps we=E2=80=99ll need to add a flag or a >> separate action later. >> >> Thoughts? > > I think this is best served by 'herd stop', followed by 'herd > start'. This patch just special-cases the 'restart' action, so > manually stopping then starting a service will behave as the old > restart used to. Great, I had overlooked this. >> For clarity, should we do an explicit =E2=80=9Cherd stop test1=E2=80=9D = followed by >> =E2=80=9Cherd start test1=E2=80=9D? I know it=E2=80=99s currently equiv= alent under the >> hood, but it might be slightly clearer. WDYT? > > Hopefully the above also answers this, too. It does, thanks! > I did consider whether it was worth adding a test for 'herd stop' to > make sure it still stops dependent services, and 'herd start' to make > sure it doesn't start dependent services, but in the end I decided not > to. I'm happy to send through another patch to test these cases, > though, if you think it would be worthwhile. No, that=E2=80=99s fine. I forgot if this was already done, but perhaps you can add a bit in the manual to insist that =E2=80=98restart=E2=80=99 is not quite the same as = =E2=80=98stop=E2=80=99 + =E2=80=98start=E2=80=99. Anyway, it all LGTM, thanks! Ludo=E2=80=99.