From: ludo@gnu.org (Ludovic Courtès)
To: Carlo Zancanaro <carlo@zancanaro.id.au>
Cc: 23170@debbugs.gnu.org
Subject: bug#23170: [PATCH shepherd] Restart dependent services on service restart
Date: Sat, 25 Aug 2018 16:41:03 +0200 [thread overview]
Message-ID: <87bm9qbjb4.fsf@gnu.org> (raw)
In-Reply-To: <874lfi65rv.fsf@zancanaro.id.au> (Carlo Zancanaro's message of "Sat, 25 Aug 2018 21:33:47 +1000")
Hi again! :-)
Carlo Zancanaro <carlo@zancanaro.id.au> skribis:
> I've written a patch to fix this. It's not super smart, but it should
> do the job.
I wonder if there are cases where one might want to restart a service
without restarting its dependent services. We can probably ignore it
for now, but perhaps we’ll need to add a flag or a separate action later.
Thoughts?
> From 50dd3ef4888b04ea3b869da893b23ad69fad8971 Mon Sep 17 00:00:00 2001
> From: Carlo Zancanaro <carlo@zancanaro.id.au>
> Date: Sat, 25 Aug 2018 20:32:11 +1000
> Subject: [PATCH] service: Restart dependent services on service restart
>
> * modules/shepherd/service.scm (required-by?): New procedure.
> (stop): Return a list of canonical-names for stopped dependent services,
> including transitive dependencies.
> (action)[restart]: Start services based on the return value of stop.
> (fold-services): New procedure.
> * tests/restart.sh: New file.
> * Makefile.am (TESTS): Add tests/restart.sh.
[...]
> +# Restart test1 and make sure that both services are still running (ie. that
> +# test2 hasn't been stopped)
> +$herd restart test1
> +$herd status test1 | grep started
> +$herd status test2 | grep started
> +
> +# Now let's test with a transitive dependency
> +$herd start test3
> +$herd status test3 | grep started
> +
> +# After restarting test1 we want test3 to still be running
> +$herd restart test1
> +$herd status test1 | grep started
> +$herd status test2 | grep started
> +$herd status test3 | grep started
For clarity, should we do an explicit “herd stop test1” followed by
“herd start test1”? I know it’s currently equivalent under the hood,
but it might be slightly clearer. WDYT?
Otherwise it LGTM. Thanks for addressing these longstanding issues!
Ludo’.
next prev parent reply other threads:[~2018-08-25 14:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 13:23 bug#23170: Shepherd doesn't restart previously running dependent services Thompson, David
2018-08-25 11:33 ` bug#23170: [PATCH shepherd] Restart dependent services on service restart Carlo Zancanaro
2018-08-25 14:41 ` Ludovic Courtès [this message]
2018-08-25 22:48 ` Carlo Zancanaro
2018-08-26 21:08 ` Ludovic Courtès
2018-08-26 22:05 ` Carlo Zancanaro
2018-08-27 11:05 ` Ludovic Courtès
2018-08-27 12:42 ` Carlo Zancanaro
2018-08-26 22:05 ` Carlo Zancanaro
2018-08-27 17:53 ` Clément Lassieur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm9qbjb4.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=23170@debbugs.gnu.org \
--cc=carlo@zancanaro.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).