From: Andrew Tropin <andrew@trop.in>
To: "Ludovic Courtès" <ludo@gnu.org>,
"Nick Zalutskiy" <nick@const.fun>,
52808@debbugs.gnu.org
Subject: bug#52808: Guix home should not assume that all targets are dot files
Date: Tue, 29 Mar 2022 12:51:59 +0300 [thread overview]
Message-ID: <87fsn1f5mo.fsf@trop.in> (raw)
In-Reply-To: <87h77sl4pn.fsf_-_@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 388 bytes --]
On 2022-03-20 22:00, Ludovic Courtès wrote:
> I wrote:
>
>> I finally got around to committing it as
>> 6da2a5a5655668f42ec5b26f875ddbc498e132b6. Thank you!
>
> I hit “close” too quickly: we still need the patch that changes
> ‘home-files-service-type’ and/or symlink-manager.scm to not prepend a
> dot, so reopening! :-)
>
> Ludo’.
A few more minor fixes:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-home-shells-Rename-zsh-related-functions.patch --]
[-- Type: text/x-patch, Size: 1947 bytes --]
From 629466d23308e135c4a46951e5ea568677c5ec00 Mon Sep 17 00:00:00 2001
From: Andrew Tropin <andrew@trop.in>
Date: Tue, 29 Mar 2022 11:15:56 +0300
Subject: [PATCH 1/2] home: shells: Rename zsh related functions.
* gnu/home/services/shells.scm (home-zsh-service-type): Make zsh related
private functions more consistently named.
---
gnu/home/services/shells.scm | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gnu/home/services/shells.scm b/gnu/home/services/shells.scm
index fb728893e3..086fe7d8c4 100644
--- a/gnu/home/services/shells.scm
+++ b/gnu/home/services/shells.scm
@@ -222,7 +222,7 @@ (define (zsh-get-configuration-files config)
,@(if (zsh-field-not-empty? config 'zlogout)
`(("zlogout" ,(zsh-file-by-field config 'zlogout))) '())))
-(define (zsh-home-files config)
+(define (add-zsh-dot-configuration config)
(define zshenv-auxiliary-file
(mixed-text-file
"zshenv-auxiliary"
@@ -233,7 +233,7 @@ (define zshenv-auxiliary-file
`(("zshenv" ,zshenv-auxiliary-file))
(zsh-get-configuration-files config)))
-(define (zsh-xdg-configuration-files config)
+(define (add-zsh-xdg-configuration config)
(if (home-zsh-configuration-xdg-flavor? config)
(map
(lambda (lst)
@@ -298,10 +298,10 @@ (define home-zsh-service-type
(extensions
(list (service-extension
home-files-service-type
- zsh-home-files)
+ add-zsh-dot-configuration)
(service-extension
home-xdg-configuration-files-service-type
- zsh-xdg-configuration-files)
+ add-zsh-xdg-configuration)
(service-extension
home-profile-service-type
add-zsh-packages)))
--
2.34.0
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.3: 0002-home-symlink-manager-Handle-non-existing-directory-d.patch --]
[-- Type: text/x-patch, Size: 1063 bytes --]
From a71346b059691a982a7dc0c7f4fd708b49566500 Mon Sep 17 00:00:00 2001
From: Andrew Tropin <andrew@trop.in>
Date: Tue, 29 Mar 2022 11:56:48 +0300
Subject: [PATCH 2/2] home: symlink-manager: Handle non-existing directory
during cleanup.
* gnu/home/services/symlink-manager.scm (update-symlinks-script): Handle
non-existing directory during cleanup.
---
gnu/home/services/symlink-manager.scm | 1 +
1 file changed, 1 insertion(+)
diff --git a/gnu/home/services/symlink-manager.scm b/gnu/home/services/symlink-manager.scm
index 3b851229f3..80ca73fed8 100644
--- a/gnu/home/services/symlink-manager.scm
+++ b/gnu/home/services/symlink-manager.scm
@@ -142,6 +142,7 @@ (define (strip file)
#t
(G_ "Skipping ~a (not an empty directory)... done\n")
directory))
+ ((= ENOENT errno) #t)
((= ENOTDIR errno) #t)
(else
(apply throw args)))))))))
--
2.34.0
[-- Attachment #1.4: Type: text/plain, Size: 39 bytes --]
--
Best regards,
Andrew Tropin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]
next prev parent reply other threads:[~2022-03-29 9:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-26 17:17 bug#52808: Guix home should not assume that all targets are dot files Nick Zalutskiy
2022-01-28 10:51 ` Andrew Tropin
2022-01-28 13:33 ` Nick Zalutskiy
2022-01-28 15:22 ` Andrew Tropin
2022-01-30 17:13 ` Ludovic Courtès
2022-02-02 8:10 ` Andrew Tropin
2022-02-08 9:46 ` Ludovic Courtès
2022-02-11 15:52 ` Andrew Tropin
2022-02-26 7:13 ` Andrew Tropin
2022-03-05 22:44 ` Ludovic Courtès
2022-03-09 4:26 ` Andrew Tropin
2022-03-10 10:56 ` Ludovic Courtès
2022-03-11 7:41 ` Andrew Tropin
2022-03-20 18:07 ` Ludovic Courtès
2022-02-08 12:58 ` Xinglu Chen
2022-02-10 20:32 ` Ludovic Courtès
[not found] ` <handler.52808.D52808.16477996643062.notifdone@debbugs.gnu.org>
2022-03-20 21:00 ` Ludovic Courtès
2022-03-28 9:17 ` Andrew Tropin
2022-03-29 9:51 ` Andrew Tropin [this message]
2022-04-10 20:52 ` Ludovic Courtès
2022-03-29 10:24 ` Andrew Tropin
2022-03-30 19:51 ` Ludovic Courtès
2022-04-08 18:18 ` Ludovic Courtès
2022-04-09 14:28 ` Andrew Tropin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsn1f5mo.fsf@trop.in \
--to=andrew@trop.in \
--cc=52808@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=nick@const.fun \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).