From: "Ludovic Courtès" <ludo@gnu.org>
To: Andrew Tropin <andrew@trop.in>
Cc: 52808@debbugs.gnu.org, Nick Zalutskiy <nick@const.fun>
Subject: bug#52808: Guix home should not assume that all targets are dot files
Date: Sat, 05 Mar 2022 23:44:27 +0100 [thread overview]
Message-ID: <871qzgm33o.fsf@gnu.org> (raw)
In-Reply-To: <87r189s8mz.fsf@trop.in> (Andrew Tropin's message of "Fri, 11 Feb 2022 18:52:36 +0300")
Hi Andrew,
The patches reached my mailbox around the time I went on vacation and
then fell through the cracks. Sorry about that!
Andrew Tropin <andrew@trop.in> skribis:
> After that patch series is merged we can give a time for users to
> migrate their self-made home services to xdg-configuration-files and
> after for example 2 weeks, remove special handling of dots for
> home-files.
Sounds like a plan!
> From 0cd37bbc724f9c793898c2655bdd1c335045c5f0 Mon Sep 17 00:00:00 2001
> From: Andrew Tropin <andrew@trop.in>
> Date: Fri, 11 Feb 2022 10:55:01 +0300
> Subject: [PATCH 1/5] home: Explicitly connect home-file and symlink-manager
> services.
>
> * gnu/home/services.scm (home-files-directory): New variable.
> * gnu/home/symlink-manager.scm (update-symlinks-script): Use
> home-files-directory variable from (gnu home services).
[...]
> - (description "Configuration files for programs that
> -will be put in @file{~/.guix-home/files}.")))
> + (description (format #f "Files that will be put in
> +@file{~~/.guix-home/~a}, and further processed during activation."
> + home-files-directory))))
This hunk would prevent i18n so I suggest dropping it (you can mention
‘home-files-directory’ in a margin comment for good measure).
Otherwise LGTM.
> From 23f7095d60b18b52de0d1aa314c4012cdf55a046 Mon Sep 17 00:00:00 2001
> From: Andrew Tropin <andrew@trop.in>
> Date: Fri, 11 Feb 2022 11:03:02 +0300
> Subject: [PATCH 2/5] home: Add home-xdg-configuration-files service.
>
> * gnu/home/services.scm (home-xdg-configuration-files): New variable.
[...]
> +(define xdg-configuration-files-subdir "config")
>
> +(define (xdg-configuration-files files)
> + (map (lambda (lst)
> + (cons (string-append xdg-configuration-files-subdir
> + "/" (car lst)) (cdr lst)))
> + files))
I’d just call it “.config” (instead of “config”). That way, there
wouldn’t be any special treatment. WDYT?
Also: s/subdir/directory/, and please use ‘match’ instead of car/cdr
(info "(guix) Coding Style").
> + (description (format #f "Files that will be put in
> +@file{~~/.guix-home/~a/~a}, and further processed during activation."
> + home-files-directory
> + xdg-configuration-files))))
Same as above: drop ‘format’ and write ~/.guix-home/files/.config.
> From 11f23a48d480a91d6bfba0ff55c1a9831585a4ee Mon Sep 17 00:00:00 2001
> From: Andrew Tropin <andrew@trop.in>
> Date: Fri, 11 Feb 2022 15:03:44 +0300
> Subject: [PATCH 3/5] home: shells: Migrate zsh to xdg-configuration-files.
>
> * gnu/home/services.scm (home-zsh-service-type): Additionally extend
> home-xdg-configuration-files-service-type.
[...]
> From ef4c3bbcc0c8c1a251f4ad6c494f8ed30adf45f2 Mon Sep 17 00:00:00 2001
> From: Andrew Tropin <andrew@trop.in>
> Date: Fri, 11 Feb 2022 15:34:46 +0300
> Subject: [PATCH 4/5] home: Migrate fountutils and xdg modules to
> xdg-configuration-files.
>
> * gnu/home/services/fontutils.scm (home-fontconfig-service-type): Migrate to
> xdg-configuration-files.
> * gnu/home/services/xdg.scm (home-xdg-user-directories-service-type,
> home-xdg-mime-applications-service-type): Migrate to xdg-configuration-files.
Neat!
> From 089683bbd301f6e085f00fbd53713f335abac40e Mon Sep 17 00:00:00 2001
> From: Andrew Tropin <andrew@trop.in>
> Date: Fri, 11 Feb 2022 16:14:23 +0300
> Subject: [PATCH 5/5] home: symlink-manager: Respect XDG_CONFIG_HOME during
> activation.
>
> * gnu/home/services/symlink-manager.scm (update-symlinks-script): Respect
> XDG_CONFIG_HOME during activation.
I propose to postpone this one after
<https://issues.guix.gnu.org/54180>, and I even offer to rebase it
myself if you want. :-)
Could you send updated patches?
Thanks in advance, and apologies again for the delay!
Ludo’.
next prev parent reply other threads:[~2022-03-05 22:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-26 17:17 bug#52808: Guix home should not assume that all targets are dot files Nick Zalutskiy
2022-01-28 10:51 ` Andrew Tropin
2022-01-28 13:33 ` Nick Zalutskiy
2022-01-28 15:22 ` Andrew Tropin
2022-01-30 17:13 ` Ludovic Courtès
2022-02-02 8:10 ` Andrew Tropin
2022-02-08 9:46 ` Ludovic Courtès
2022-02-11 15:52 ` Andrew Tropin
2022-02-26 7:13 ` Andrew Tropin
2022-03-05 22:44 ` Ludovic Courtès [this message]
2022-03-09 4:26 ` Andrew Tropin
2022-03-10 10:56 ` Ludovic Courtès
2022-03-11 7:41 ` Andrew Tropin
2022-03-20 18:07 ` Ludovic Courtès
2022-02-08 12:58 ` Xinglu Chen
2022-02-10 20:32 ` Ludovic Courtès
[not found] ` <handler.52808.D52808.16477996643062.notifdone@debbugs.gnu.org>
2022-03-20 21:00 ` Ludovic Courtès
2022-03-28 9:17 ` Andrew Tropin
2022-03-29 9:51 ` Andrew Tropin
2022-04-10 20:52 ` Ludovic Courtès
2022-03-29 10:24 ` Andrew Tropin
2022-03-30 19:51 ` Ludovic Courtès
2022-04-08 18:18 ` Ludovic Courtès
2022-04-09 14:28 ` Andrew Tropin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qzgm33o.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=52808@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=nick@const.fun \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).