unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#40613: [PATCH] gnu: Add emacs-typing.
@ 2020-04-14  0:11 Alberto Eleuterio Flores Guerrero
  2020-04-14  0:55 ` bug#40613: (no subject) Tobias Geerinckx-Rice
  2020-04-14 21:47 ` bug#40613: [PATCH] gnu: Add emacs-typing Nicolas Goaziou
  0 siblings, 2 replies; 4+ messages in thread
From: Alberto Eleuterio Flores Guerrero @ 2020-04-14  0:11 UTC (permalink / raw)
  To: 40613

* gnu/packages/emacs-xyz.scm (emacs-typing): New variable.
---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d3631535da..6acbee00d3 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -22499,3 +22499,25 @@ which can be embedded in source code, comments or emails.")
 @code{4clojure.com} problems, you can open an specific question and move
 the next or previos.  You can also check you answers.")
    (license license:gpl3)))
+
+(define-public emacs-typing
+  (package
+    (name "emacs-typing")
+    (version "1.1.4")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/kensanata/typing.git")
+             (commit "a2ef25dde2d8eb91bd9c0c6164cb5208208647fa")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1dbh0srbf54lgd60ia79y9cfnq3kxlgw01qzdjs9mk3nfazzpgnv"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/kensanata/typing/")
+    (synopsis "Emacs game where you have to type fast")
+    (description "@code{emacs-typing} is a game for Emacs that
+forces you to type words correctly as fast as possible, otherwise
+you will die.  The game builds the list of words from the active buffer")
+    (license license:gpl2)))
-- 
2.26.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#40613: (no subject)
  2020-04-14  0:11 bug#40613: [PATCH] gnu: Add emacs-typing Alberto Eleuterio Flores Guerrero
@ 2020-04-14  0:55 ` Tobias Geerinckx-Rice
  2020-04-14 21:47 ` bug#40613: [PATCH] gnu: Add emacs-typing Nicolas Goaziou
  1 sibling, 0 replies; 4+ messages in thread
From: Tobias Geerinckx-Rice @ 2020-04-14  0:55 UTC (permalink / raw)
  To: 40591, 40593, 40616, 40613

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

For the record (and any reviewers), these patches should be 
applied in order:

#40591 emacs-org-roam
#40593 emacs-uml-mode
#40616 emacs-4clojure
#40613 emacs-typing

They're not interdependent, just patch-context-dependent.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#40613: [PATCH] gnu: Add emacs-typing.
  2020-04-14  0:11 bug#40613: [PATCH] gnu: Add emacs-typing Alberto Eleuterio Flores Guerrero
  2020-04-14  0:55 ` bug#40613: (no subject) Tobias Geerinckx-Rice
@ 2020-04-14 21:47 ` Nicolas Goaziou
  2020-10-22 21:33   ` Maxim Cournoyer
  1 sibling, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2020-04-14 21:47 UTC (permalink / raw)
  To: Alberto Eleuterio Flores Guerrero; +Cc: 40613

Hello,

Alberto Eleuterio Flores Guerrero <barbanegra+guix@posteo.mx> writes:

> * gnu/packages/emacs-xyz.scm (emacs-typing): New variable.

Thank you.

> +(define-public emacs-typing
> +  (package
> +    (name "emacs-typing")
> +    (version "1.1.4")

This is not a regular release, this is extracted from the main file. We
need to provide a commit and a revision. See, e.g., "emacs-dhall-mode".

> +    (description "@code{emacs-typing} is a game for Emacs that

I would write "The Typing of Emacs" instead of emacs-typing, i.e., the
name of the game instead of the symbol.

> +forces you to type words correctly as fast as possible, otherwise
> +you will die.  The game builds the list of words from the active buffer")

The description is missing a final dot.

> +    (license license:gpl2)))

The license is gpl2+.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#40613: [PATCH] gnu: Add emacs-typing.
  2020-04-14 21:47 ` bug#40613: [PATCH] gnu: Add emacs-typing Nicolas Goaziou
@ 2020-10-22 21:33   ` Maxim Cournoyer
  0 siblings, 0 replies; 4+ messages in thread
From: Maxim Cournoyer @ 2020-10-22 21:33 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: 40613-done, Alberto Eleuterio Flores Guerrero

Hello Nicolas, Alberto,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Alberto Eleuterio Flores Guerrero <barbanegra+guix@posteo.mx> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-typing): New variable.
>
> Thank you.
>
>> +(define-public emacs-typing
>> +  (package
>> +    (name "emacs-typing")
>> +    (version "1.1.4")
>
> This is not a regular release, this is extracted from the main file. We
> need to provide a commit and a revision. See, e.g., "emacs-dhall-mode".
>
>> +    (description "@code{emacs-typing} is a game for Emacs that
>
> I would write "The Typing of Emacs" instead of emacs-typing, i.e., the
> name of the game instead of the symbol.
>
>> +forces you to type words correctly as fast as possible, otherwise
>> +you will die.  The game builds the list of words from the active buffer")
>
> The description is missing a final dot.
>
>> +    (license license:gpl2)))
>
> The license is gpl2+.
>
> Could you send an updated patch?

I modified the original definition with your above suggestions and
pushed as commit a49bfa1f6c22363c9e495070f51b82e60b1495af.

Closing.

Thank you!

Maxim




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-10-22 21:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-14  0:11 bug#40613: [PATCH] gnu: Add emacs-typing Alberto Eleuterio Flores Guerrero
2020-04-14  0:55 ` bug#40613: (no subject) Tobias Geerinckx-Rice
2020-04-14 21:47 ` bug#40613: [PATCH] gnu: Add emacs-typing Nicolas Goaziou
2020-10-22 21:33   ` Maxim Cournoyer

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).