From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: bug#40613: [PATCH] gnu: Add emacs-typing.
Date: Tue, 14 Apr 2020 23:47:26 +0200
Message-ID: <875ze13fkh.fsf@nicolasgoaziou.fr>
References: <20200414001124.12373-1-barbanegra+guix@posteo.mx>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:35204)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jOTPX-0000mJ-43
 for bug-guix@gnu.org; Tue, 14 Apr 2020 17:48:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jOTPW-0003OE-7l
 for bug-guix@gnu.org; Tue, 14 Apr 2020 17:48:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:51611)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jOTPW-0003Nz-4u
 for bug-guix@gnu.org; Tue, 14 Apr 2020 17:48:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jOTPW-0000NU-1u
 for bug-guix@gnu.org; Tue, 14 Apr 2020 17:48:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.40613.B40613.15869008571420@debbugs.gnu.org>
In-Reply-To: <20200414001124.12373-1-barbanegra+guix@posteo.mx> (Alberto
 Eleuterio Flores Guerrero's message of "Mon, 13 Apr 2020
 19:11:24 -0500")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
To: Alberto Eleuterio Flores Guerrero <barbanegra+guix@posteo.mx>
Cc: 40613@debbugs.gnu.org

Hello,

Alberto Eleuterio Flores Guerrero <barbanegra+guix@posteo.mx> writes:

> * gnu/packages/emacs-xyz.scm (emacs-typing): New variable.

Thank you.

> +(define-public emacs-typing
> +  (package
> +    (name "emacs-typing")
> +    (version "1.1.4")

This is not a regular release, this is extracted from the main file. We
need to provide a commit and a revision. See, e.g., "emacs-dhall-mode".

> +    (description "@code{emacs-typing} is a game for Emacs that

I would write "The Typing of Emacs" instead of emacs-typing, i.e., the
name of the game instead of the symbol.

> +forces you to type words correctly as fast as possible, otherwise
> +you will die.  The game builds the list of words from the active buffer")

The description is missing a final dot.

> +    (license license:gpl2)))

The license is gpl2+.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou