unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: 45570@debbugs.gnu.org, conjaroy@gmail.com
Subject: bug#45570: [PATCH v2] system: Assert, that user and group names are unique.
Date: Thu, 07 Jan 2021 09:35:43 +0100	[thread overview]
Message-ID: <87czyhjg9s.fsf@gnu.org> (raw)
In-Reply-To: <20210106212148.28720-1-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Wed, 6 Jan 2021 22:21:49 +0100")

Leo Prikler <leo.prikler@student.tugraz.at> skribis:

> *gnu/system/shadow.scm (find-duplicates): New variable.
> (assert-unique-account-names, assert-unique-group-names): New variables.
> (account-activation): Use them here.

Final nitpicks!  :-)

> +(define (find-duplicates list)

Please add a docstring.

> +  (let loop ((table (make-hash-table))
> +             (list list))

You can move ‘table’ out of the ‘loop’ arguments since it’s mutated
anyway.

OK with these changes!

Thanks,
Ludo’.




  reply	other threads:[~2021-01-07  8:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-31 18:14 bug#45570: operating-system definitions allow duplicate passwd and group entries Jason Conroy
2021-01-01 11:13 ` bug#45570: [PATCH] system: Assert, that user and group names are unique Leo Prikler
2021-01-02  1:16   ` Danny Milosavljevic
2021-01-02  5:57 ` Leo Prikler
2021-01-06  9:56   ` Ludovic Courtès
2021-01-06 12:34     ` Leo Prikler
2021-01-06 13:32       ` Ludovic Courtès
2021-01-06 21:00         ` Leo Prikler
2021-01-07  8:29           ` Ludovic Courtès
2021-01-06 21:21 ` bug#45570: [PATCH v2] " Leo Prikler
2021-01-07  8:35   ` Ludovic Courtès [this message]
2021-01-07 11:13     ` Leo Prikler
2021-01-07 11:10 ` bug#45570: [PATCH v3] " Leo Prikler
2021-01-11 13:09   ` Ludovic Courtès
2021-01-11 15:06     ` Leo Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czyhjg9s.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=45570@debbugs.gnu.org \
    --cc=conjaroy@gmail.com \
    --cc=leo.prikler@student.tugraz.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).