From: Leo Prikler <leo.prikler@student.tugraz.at>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 45570@debbugs.gnu.org, conjaroy@gmail.com
Subject: bug#45570: [PATCH v2] system: Assert, that user and group names are unique.
Date: Thu, 07 Jan 2021 12:13:31 +0100 [thread overview]
Message-ID: <08d83d415bc59d7b86dc7233f48ece7d909069f2.camel@student.tugraz.at> (raw)
In-Reply-To: <87czyhjg9s.fsf@gnu.org>
Am Donnerstag, den 07.01.2021, 09:35 +0100 schrieb Ludovic Courtès:
> Leo Prikler <leo.prikler@student.tugraz.at> skribis:
>
> > *gnu/system/shadow.scm (find-duplicates): New variable.
> > (assert-unique-account-names, assert-unique-group-names): New
> > variables.
> > (account-activation): Use them here.
>
> Final nitpicks! :-)
>
> > +(define (find-duplicates list)
>
> Please add a docstring.
Done, see v3.
> > + (let loop ((table (make-hash-table))
> > + (list list))
>
> You can move ‘table’ out of the ‘loop’ arguments since it’s mutated
> anyway.
I don't see any benefit from doing so, however. It'd be an additional
layer of mutation and if we ever wanted to change to vhashes or alists
we'd have to refactor that.
Regards,
Leo
next prev parent reply other threads:[~2021-01-07 11:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 18:14 bug#45570: operating-system definitions allow duplicate passwd and group entries Jason Conroy
2021-01-01 11:13 ` bug#45570: [PATCH] system: Assert, that user and group names are unique Leo Prikler
2021-01-02 1:16 ` Danny Milosavljevic
2021-01-02 5:57 ` Leo Prikler
2021-01-06 9:56 ` Ludovic Courtès
2021-01-06 12:34 ` Leo Prikler
2021-01-06 13:32 ` Ludovic Courtès
2021-01-06 21:00 ` Leo Prikler
2021-01-07 8:29 ` Ludovic Courtès
2021-01-06 21:21 ` bug#45570: [PATCH v2] " Leo Prikler
2021-01-07 8:35 ` Ludovic Courtès
2021-01-07 11:13 ` Leo Prikler [this message]
2021-01-07 11:10 ` bug#45570: [PATCH v3] " Leo Prikler
2021-01-11 13:09 ` Ludovic Courtès
2021-01-11 15:06 ` Leo Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08d83d415bc59d7b86dc7233f48ece7d909069f2.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=45570@debbugs.gnu.org \
--cc=conjaroy@gmail.com \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).