From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OKgSK/vH9l/nJgAA0tVLHw (envelope-from ) for ; Thu, 07 Jan 2021 08:36:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qMPWJvvH9l9uDwAA1q6Kng (envelope-from ) for ; Thu, 07 Jan 2021 08:36:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0B62F9403D2 for ; Thu, 7 Jan 2021 08:36:11 +0000 (UTC) Received: from localhost ([::1]:59716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxQm9-0007XR-LA for larch@yhetil.org; Thu, 07 Jan 2021 03:36:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxQm2-0007X1-M7 for bug-guix@gnu.org; Thu, 07 Jan 2021 03:36:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34707) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kxQm2-0005Zq-Eh for bug-guix@gnu.org; Thu, 07 Jan 2021 03:36:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kxQm2-0003Ex-CV for bug-guix@gnu.org; Thu, 07 Jan 2021 03:36:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#45570: [PATCH v2] system: Assert, that user and group names are unique. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 07 Jan 2021 08:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45570 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Leo Prikler Received: via spool by 45570-submit@debbugs.gnu.org id=B45570.161000855312439 (code B ref 45570); Thu, 07 Jan 2021 08:36:02 +0000 Received: (at 45570) by debbugs.gnu.org; 7 Jan 2021 08:35:53 +0000 Received: from localhost ([127.0.0.1]:46253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxQls-0003EZ-TR for submit@debbugs.gnu.org; Thu, 07 Jan 2021 03:35:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxQlq-0003EM-FT for 45570@debbugs.gnu.org; Thu, 07 Jan 2021 03:35:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51828) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxQll-0005SN-7U; Thu, 07 Jan 2021 03:35:45 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=43786 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kxQlk-0002Qc-Kj; Thu, 07 Jan 2021 03:35:44 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210106212148.28720-1-leo.prikler@student.tugraz.at> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 18 =?UTF-8?Q?Niv=C3=B4se?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 07 Jan 2021 09:35:43 +0100 In-Reply-To: <20210106212148.28720-1-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Wed, 6 Jan 2021 22:21:49 +0100") Message-ID: <87czyhjg9s.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45570@debbugs.gnu.org, conjaroy@gmail.com Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.84 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 0B62F9403D2 X-Spam-Score: -2.84 X-Migadu-Scanner: scn0.migadu.com X-TUID: 22mMILe7s3LJ Leo Prikler skribis: > *gnu/system/shadow.scm (find-duplicates): New variable. > (assert-unique-account-names, assert-unique-group-names): New variables. > (account-activation): Use them here. Final nitpicks! :-) > +(define (find-duplicates list) Please add a docstring. > + (let loop ((table (make-hash-table)) > + (list list)) You can move =E2=80=98table=E2=80=99 out of the =E2=80=98loop=E2=80=99 argu= ments since it=E2=80=99s mutated anyway. OK with these changes! Thanks, Ludo=E2=80=99.