bug#68429: Catch2-3.5.1 tests fails on i686-linux, SSE extension

bug#68429: Catch2-3.5.1 tests fails on i686-linux, SSE extension

[Richard Sent]

[-- Attachment #1: Type: text/plain, Size: 835 bytes --]

Opening a ticket so discussions a bit more organized. Hope this doesn't 
step on anybody's toes.

Catch2-3.5.1 fails to build with system=i686-linux, log attached. This 
is due to a test added upstream that assumes the SSE extension is 
present, 
SelfTest/IntrospectiveTests/RandomNumberGeneration.tests.cpp:570.

One fix was proposed that replaces GCC with Clang, attached. This works 
because Clang assumes the SSE extension by default. If we add 
"-DCMAKE_CXX_FLAGS=-mno-sse", the test fails again.

Another solution is to add "-DCMAKE_CXX_FLAGS=-msse -mfpmath=sse" to the 
existing package definition.

Of the two, the second is more explicit in how the problem is resolved, 
but I don't know if we should assume SSE is present on i686.

An issue was opened upstream at 
https://github.com/catchorg/Catch2/issues/2796

Richard Sent

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: clang-fix.diff --]
[-- Type: text/x-diff; name=clang-fix.diff, Size: 865 bytes --]

diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
index 449340f331..e09a7bd82a 100644
--- a/gnu/packages/check.scm
+++ b/gnu/packages/check.scm
@@ -621,9 +621,14 @@ (define-public catch2-3
     (arguments
      (list
       #:configure-flags
-      #~(list "-DCATCH_DEVELOPMENT_BUILD=ON"
+      #~(list "-DCMAKE_CXX_COMPILER=clang++" ; tests fail with gcc-11 on i686
+              "-DCMAKE_CXX_STANDARD=14"
+              "-DCMAKE_CXX_STANDARD_REQUIRED=ON"
+              "-DCMAKE_CXX_EXTENSIONS=OFF"
+              "-DCATCH_DEVELOPMENT_BUILD=ON"
               "-DCATCH_ENABLE_WERROR=OFF"
               "-DBUILD_SHARED_LIBS=ON")))
+    (native-inputs (list clang-10))
     (inputs (list python-wrapper))
     (synopsis "Automated test framework for C++ and Objective-C")
     (description "Catch2 stands for C++ Automated Test Cases in Headers and is

[-- Attachment #3: sll1zarpy78qi6fgrz9xrpx99hhn3b-catch2-3.5.1.drv.gz --]
[-- Type: application/gzip, Size: 21759 bytes --]

bug#68429: Catch2-3.5.1 tests fails on i686-linux, SSE extension

[John Kehayias via Bug reports for GNU Guix]

Hi,

On Sat, Jan 13, 2024 at 11:43 AM, Richard Sent wrote:

> Opening a ticket so discussions a bit more organized. Hope this
> doesn't step on anybody's toes.
>
> Catch2-3.5.1 fails to build with system=i686-linux, log attached. This
> is due to a test added upstream that assumes the SSE extension is
> present,
> SelfTest/IntrospectiveTests/RandomNumberGeneration.tests.cpp:570.
>
> One fix was proposed that replaces GCC with Clang, attached. This
> works because Clang assumes the SSE extension by default. If we add
> "-DCMAKE_CXX_FLAGS=-mno-sse", the test fails again.
>
> Another solution is to add "-DCMAKE_CXX_FLAGS=-msse -mfpmath=sse" to
> the existing package definition.
>
> Of the two, the second is more explicit in how the problem is
> resolved, but I don't know if we should assume SSE is present on i686.
>

Thanks! Looking at other packages, seems it is find to enable SSE, just
for x86_64 and i686. Other times we explicitly disable SSE2 more
generally, but in this case it makes sense to match upstream (unless
they change this) and enable in these cases.

So, I used that configure flag just for those systems in
18393fcdddf5c3d834fa89ebf5f3925fc5b166ed which I've pushed. I added you
and another (Jo Gay, from the other channel) as co-authors for finding
the fix(es).

> An issue was opened upstream at
> https://github.com/catchorg/Catch2/issues/2796
>

And thanks for this too!

John

> Richard Sent
>
> diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
> index 449340f331..e09a7bd82a 100644
> --- a/gnu/packages/check.scm
> +++ b/gnu/packages/check.scm
> @@ -621,9 +621,14 @@ (define-public catch2-3
>      (arguments
>       (list
>        #:configure-flags
> -      #~(list "-DCATCH_DEVELOPMENT_BUILD=ON"
> +      #~(list "-DCMAKE_CXX_COMPILER=clang++" ; tests fail with gcc-11 on i686
> +              "-DCMAKE_CXX_STANDARD=14"
> +              "-DCMAKE_CXX_STANDARD_REQUIRED=ON"
> +              "-DCMAKE_CXX_EXTENSIONS=OFF"
> +              "-DCATCH_DEVELOPMENT_BUILD=ON"
>                "-DCATCH_ENABLE_WERROR=OFF"
>                "-DBUILD_SHARED_LIBS=ON")))
> +    (native-inputs (list clang-10))
>      (inputs (list python-wrapper))
>      (synopsis "Automated test framework for C++ and Objective-C")
>      (description "Catch2 stands for C++ Automated Test Cases in Headers and is

bug#68429: Catch2-3.5.1 tests fails on i686-linux, SSE extension

[John Kehayias via Bug reports for GNU Guix]

Hi,

On Sat, Jan 13, 2024 at 11:43 AM, Richard Sent wrote:

> Opening a ticket so discussions a bit more organized. Hope this
> doesn't step on anybody's toes.
>
> Catch2-3.5.1 fails to build with system=i686-linux, log attached. This
> is due to a test added upstream that assumes the SSE extension is
> present,
> SelfTest/IntrospectiveTests/RandomNumberGeneration.tests.cpp:570.
>
> One fix was proposed that replaces GCC with Clang, attached. This
> works because Clang assumes the SSE extension by default. If we add
> "-DCMAKE_CXX_FLAGS=-mno-sse", the test fails again.
>
> Another solution is to add "-DCMAKE_CXX_FLAGS=-msse -mfpmath=sse" to
> the existing package definition.
>
> Of the two, the second is more explicit in how the problem is
> resolved, but I don't know if we should assume SSE is present on i686.
>

Thanks! Looking at other packages, seems it is find to enable SSE, just
for x86_64 and i686. Other times we explicitly disable SSE2 more
generally, but in this case it makes sense to match upstream (unless
they change this) and enable in these cases.

So, I used that configure flag just for those systems in
18393fcdddf5c3d834fa89ebf5f3925fc5b166ed which I've pushed. I added you
and another (Jo Gay, from the other channel) as co-authors for finding
the fix(es).

> An issue was opened upstream at
> https://github.com/catchorg/Catch2/issues/2796
>

And thanks for this too!

John

> Richard Sent
>
> diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
> index 449340f331..e09a7bd82a 100644
> --- a/gnu/packages/check.scm
> +++ b/gnu/packages/check.scm
> @@ -621,9 +621,14 @@ (define-public catch2-3
>      (arguments
>       (list
>        #:configure-flags
> -      #~(list "-DCATCH_DEVELOPMENT_BUILD=ON"
> +      #~(list "-DCMAKE_CXX_COMPILER=clang++" ; tests fail with gcc-11 on i686
> +              "-DCMAKE_CXX_STANDARD=14"
> +              "-DCMAKE_CXX_STANDARD_REQUIRED=ON"
> +              "-DCMAKE_CXX_EXTENSIONS=OFF"
> +              "-DCATCH_DEVELOPMENT_BUILD=ON"
>                "-DCATCH_ENABLE_WERROR=OFF"
>                "-DBUILD_SHARED_LIBS=ON")))
> +    (native-inputs (list clang-10))
>      (inputs (list python-wrapper))
>      (synopsis "Automated test framework for C++ and Objective-C")
>      (description "Catch2 stands for C++ Automated Test Cases in Headers and is