From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id uLt1NGUVo2XJngAA62LTzQ:P1 (envelope-from ) for ; Sat, 13 Jan 2024 23:57:42 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id uLt1NGUVo2XJngAA62LTzQ (envelope-from ) for ; Sat, 13 Jan 2024 23:57:41 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=fGnsTdBl; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705186661; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=8ebCYunJsZhwNbCebtYrT4TBwkS9tZMhEQBn3l9pyDU=; b=eApSvrJxUjvkNMMJFOg8Q28VzmUzsbDJtjjEiaAbL0IG1zV0G8CH8CFn6KrOEaR1GrGo+Y Uin4gQajOfvrXsOlBGv27siGtcNYbM5RqCU+u0opha0bK7GRnPhYyDwwOWjjJR1g0pb5Ta j90J1tm6Qbq/LtkiL+y8L7XgsVyLerSJ6IdGX1tdPKOnHZfYBfheXU4/atM9ksA69jzBzr Myg3XE684o8PKua6eoAtNbyUvNgTRrnNfZjU8rgwkXP5TQ7sbvRty2BFrAE7XuTKhhY9kc Osr19VJHgTfmh2LWX4nPJ9Xb7/lA9CQGGzvZa6bgeRvgu0F4OBcGzjX+wPnf0Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705186661; a=rsa-sha256; cv=none; b=i5f4jnyOewKHVHbbRnKiXYqAYHxUQ0CxFe7HuB88JjZC+Z/L8zO5WC5laFfVy26FqVBpjj zy2f3KPgJhpUtgfxjTgnbNX+8uJ+xcUwJOfhAyojAtFUE42H98s9s3KgNMSNkxNcN3l6Rs HsQbD2Ihd4GzydGSBFkr11vyKLXjMBmW0YmgU4OFcy8uKW08WblcShWuKRffnet3+bY9MS S/9cqnP8f7la/zi9/8YNaD1qfRW+jjDmtzO8iaDAWyJZQrGQE3sfPs1ogTuCXDx6hiSyFl wLmB4cWHDdkOdbLqvv4Sq4bomRT0TqlIfzItF3acwzA1Y2vZo3Fm4vs62X6W4A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=fGnsTdBl; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 88F336E810 for ; Sat, 13 Jan 2024 23:57:41 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOmw6-0001a6-DV; Sat, 13 Jan 2024 17:57:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOmw4-0001ZR-Hk for bug-guix@gnu.org; Sat, 13 Jan 2024 17:57:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rOmw3-0002JC-NG for bug-guix@gnu.org; Sat, 13 Jan 2024 17:57:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rOmw2-0004Xs-1Y for bug-guix@gnu.org; Sat, 13 Jan 2024 17:57:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#68429: Catch2-3.5.1 tests fails on i686-linux, SSE extension References: <3e5407f77e0e70bafed2f11eed692cdc@freakingpenguin.com> In-Reply-To: <3e5407f77e0e70bafed2f11eed692cdc@freakingpenguin.com> Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 13 Jan 2024 22:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68429 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Richard Sent Cc: 68429@debbugs.gnu.org Received: via spool by 68429-submit@debbugs.gnu.org id=B68429.170518660717428 (code B ref 68429); Sat, 13 Jan 2024 22:57:02 +0000 Received: (at 68429) by debbugs.gnu.org; 13 Jan 2024 22:56:47 +0000 Received: from localhost ([127.0.0.1]:41314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOmvm-0004X1-Hy for submit@debbugs.gnu.org; Sat, 13 Jan 2024 17:56:46 -0500 Received: from mail-40133.protonmail.ch ([185.70.40.133]:61991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOmvk-0004Wf-K0 for 68429@debbugs.gnu.org; Sat, 13 Jan 2024 17:56:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1705186599; x=1705445799; bh=8ebCYunJsZhwNbCebtYrT4TBwkS9tZMhEQBn3l9pyDU=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=fGnsTdBlhRMSuDrY24SpHThtY/gsGrH94q/6nr1y0a8TxFxMOSgIrllNcXZr6DKdT 2JUFnGyYydJIr7tCgMK+iIPXKKp6TLNxrB59o6dlDxW/R0S+Lt/OV75nmFCMZhyglu S9xUFNn6GOErH7+vNP2klWzPo3cxp2vsP+UzN2xs/1t+b3SS5Rt7cIj8tMKM6tq1Zw 6dVob/+K+Zsm9R/FhBmFlCRD6G9dEz5ZIaqgm5TSH/ZAu5S837a693JHSzxtzb7Z+/ zwEjTkKvl34GFwHeCSU+DVm516u0kdLYDIJlDtWR+SKk/BSu1/YNwINCzFj6zoFO8O 1pRS2347Ph2lQ== Date: Sat, 13 Jan 2024 22:56:20 +0000 Message-ID: <87a5p8c06r.fsf@protonmail.com> Feedback-ID: 7805494:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: John Kehayias From: John Kehayias via Bug reports for GNU Guix Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -7.20 X-Spam-Score: -7.20 X-Migadu-Queue-Id: 88F336E810 X-TUID: IY/lSml6+dSv Hi, On Sat, Jan 13, 2024 at 11:43 AM, Richard Sent wrote: > Opening a ticket so discussions a bit more organized. Hope this > doesn't step on anybody's toes. > > Catch2-3.5.1 fails to build with system=3Di686-linux, log attached. This > is due to a test added upstream that assumes the SSE extension is > present, > SelfTest/IntrospectiveTests/RandomNumberGeneration.tests.cpp:570. > > One fix was proposed that replaces GCC with Clang, attached. This > works because Clang assumes the SSE extension by default. If we add > "-DCMAKE_CXX_FLAGS=3D-mno-sse", the test fails again. > > Another solution is to add "-DCMAKE_CXX_FLAGS=3D-msse -mfpmath=3Dsse" to > the existing package definition. > > Of the two, the second is more explicit in how the problem is > resolved, but I don't know if we should assume SSE is present on i686. > Thanks! Looking at other packages, seems it is find to enable SSE, just for x86_64 and i686. Other times we explicitly disable SSE2 more generally, but in this case it makes sense to match upstream (unless they change this) and enable in these cases. So, I used that configure flag just for those systems in 18393fcdddf5c3d834fa89ebf5f3925fc5b166ed which I've pushed. I added you and another (Jo Gay, from the other channel) as co-authors for finding the fix(es). > An issue was opened upstream at > https://github.com/catchorg/Catch2/issues/2796 > And thanks for this too! John > Richard Sent > > diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm > index 449340f331..e09a7bd82a 100644 > --- a/gnu/packages/check.scm > +++ b/gnu/packages/check.scm > @@ -621,9 +621,14 @@ (define-public catch2-3 > (arguments > (list > #:configure-flags > - #~(list "-DCATCH_DEVELOPMENT_BUILD=3DON" > + #~(list "-DCMAKE_CXX_COMPILER=3Dclang++" ; tests fail with gcc-11 = on i686 > + "-DCMAKE_CXX_STANDARD=3D14" > + "-DCMAKE_CXX_STANDARD_REQUIRED=3DON" > + "-DCMAKE_CXX_EXTENSIONS=3DOFF" > + "-DCATCH_DEVELOPMENT_BUILD=3DON" > "-DCATCH_ENABLE_WERROR=3DOFF" > "-DBUILD_SHARED_LIBS=3DON"))) > + (native-inputs (list clang-10)) > (inputs (list python-wrapper)) > (synopsis "Automated test framework for C++ and Objective-C") > (description "Catch2 stands for C++ Automated Test Cases in Headers = and is